Fix retro settings request body validation

StevenWeathers · Oct 16, 2024 · 8e1f9a0 · 8e1f9a0
1 parent 23179d7
commit 8e1f9a0
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 7 deletions.
diff --git a/docs/swagger/docs.go b/docs/swagger/docs.go
@@ -12425,7 +12425,8 @@ const docTemplate = `{
                     "type": "string",
                     "enum": [
                         "visible",
-                        "hidden"
+                        "hidden",
+                        "concealed"
                     ]
                 },
                 "facilitatorCode": {
@@ -12444,7 +12445,7 @@ const docTemplate = `{
                 },
                 "phaseTimeLimit": {
                     "type": "integer",
-                    "maximum": 120,
+                    "maximum": 59,
                     "minimum": 0
                 },
                 "templateId": {

diff --git a/docs/swagger/swagger.json b/docs/swagger/swagger.json
@@ -12417,7 +12417,8 @@
                     "type": "string",
                     "enum": [
                         "visible",
-                        "hidden"
+                        "hidden",
+                        "concealed"
                     ]
                 },
                 "facilitatorCode": {
@@ -12436,7 +12437,7 @@
                 },
                 "phaseTimeLimit": {
                     "type": "integer",
-                    "maximum": 120,
+                    "maximum": 59,
                     "minimum": 0
                 },
                 "templateId": {

diff --git a/docs/swagger/swagger.yaml b/docs/swagger/swagger.yaml
@@ -428,6 +428,7 @@ definitions:
         enum:
         - visible
         - hidden
+        - concealed
         type: string
       facilitatorCode:
         type: string
@@ -440,7 +441,7 @@ definitions:
       phaseAutoAdvance:
         type: boolean
       phaseTimeLimit:
-        maximum: 120
+        maximum: 59
         minimum: 0
         type: integer
       templateId:

diff --git a/internal/http/retrosettings.go b/internal/http/retrosettings.go
@@ -15,8 +15,8 @@ import (
 type retroSettingsRequestBody struct {
 	MaxVotes              int16   `json:"maxVotes" validate:"gte=1,lte=100"`
 	AllowMultipleVotes    bool    `json:"allowMultipleVotes"`
-	BrainstormVisibility  string  `json:"brainstormVisibility" validate:"oneof=visible hidden"`
-	PhaseTimeLimit        int16   `json:"phaseTimeLimit" validate:"gte=0,lte=120"`
+	BrainstormVisibility  string  `json:"brainstormVisibility" validate:"oneof=visible hidden concealed"`
+	PhaseTimeLimit        int16   `json:"phaseTimeLimit" validate:"gte=0,lte=59"`
 	PhaseAutoAdvance      bool    `json:"phaseAutoAdvance"`
 	AllowCumulativeVoting bool    `json:"allowCumulativeVoting"`
 	TemplateID            *string `json:"templateId" validate:"omitempty,uuid"`