Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementing method in BMS service for equals block #152

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Implementing method in BMS service for equals block #152

wants to merge 2 commits into from

Conversation

Lexsus
Copy link
Contributor

@Lexsus Lexsus commented May 17, 2018

kosmoflyko
kosmoflyko requested changes May 17, 2018
View reviewed changes
Copy link
Contributor

@kosmoflyko kosmoflyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix minor changes

...c/main/java/com/stnetix/ariaddna/blockmanipulation/service/BlockManipulationServiceImpl.java Outdated
}

@Override
public boolean checkBlock(Block block, Metatable metatable) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change name of method to "isExistOnVufs"

.../src/main/java/com/stnetix/ariaddna/blockmanipulation/service/IBlockManipulationService.java Outdated
* @param metatable Metatable object
* @return return true if Metatable contains block and otherwise return false
*/
boolean checkBlock(Block block,Metatable metatable);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change name of method to "isExistOnVufs"

...st/java/com/stnetix/ariaddna/blockmanipulation/service/BlockManipulationServiceImplTest.java
@@ -81,6 +88,51 @@ public void getNextBlockUuid() throws BlockDoesNotExistException, MetafileIsFold
blockManipulationService.getNextBlockUuid(metafile);
}

@Test
public void CheckBlock() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please change name of method to "isExistOnVufs"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kosmoflyko kosmoflyko kosmoflyko requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lexsus @kosmoflyko