Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Xcode, macOS, iOS targets #7104

Merged
merged 24 commits into from
Mar 3, 2024
Merged

Upgrade Xcode, macOS, iOS targets #7104

merged 24 commits into from
Mar 3, 2024

Conversation

drewvolz
Copy link
Member

@drewvolz drewvolz commented Feb 20, 2024

  • bump to Xcode 15.2
  • bump to macOS 14.2
  • bump to iOS 17.2

configs
- merge metro configs
- set jest preset to react-native
- podfile config changes for hoisting with node

dependencies
- bump metro-react-native-babel-preset to 0.76.8
- add @react-native/eslint-config  ^0.72.2
- add @react-native/metro-config ^0.72.11
- add @tsconfig/react-native ^3.0.0
- set node engines >=18
- working for android
- broken for iOS, tracking react-native-reanimated/issues/4522
* target Xcode 15.2
* target macOS 14.2
* target iOS 17.2
@drewvolz
Copy link
Member Author

drewvolz commented Feb 20, 2024

I can lower the macOS runner target from 14.2 if we continue to get stuck at the following spot in CI

Waiting for a runner to pick up this job...
This request was automatically failed because there were no enabled runners online to process the request
for more than 1 days.

@rye
Copy link
Member

rye commented Feb 24, 2024

New problem:

/Users/runner/work/AAO-React-Native/AAO-React-Native/ios/AllAboutOlaf.xcodeproj: error: No profile for team 'TMK6S7TPX2' matching 'match AppStore NFMTHAZVS9.com.drewvolz.stolaf' found: Xcode couldn't find any provisioning profiles matching 'TMK6S7TPX2/match AppStore NFMTHAZVS9.com.drewvolz.stolaf'. Install the profile (by dragging and dropping it onto Xcode's dock item) or select a different one in the Signing & Capabilities tab of the target editor. (in target 'AllAboutOlaf' from project 'AllAboutOlaf')
note: Run script build phase 'Bundle React Native code and images' will be run during every build because the option to run the script phase "Based on dependency analysis" is unchecked. (in target 'AllAboutOlaf' from project 'AllAboutOlaf')

@drewvolz
Copy link
Member Author

drewvolz commented Feb 24, 2024

  • 1. Getting provisioning settled is one thing (although nightlies are somehow not broken from all this fun).

  • 2. Likely the next thing we'll come across is a build error related to depending on the newer Xcode 15 with the older React Native version of v71.1.

    [21:48:49]: ▸ ::error file=/Users/runner/work/AAO-React-Native/AAO-React-    Native/ios/Pods/boost/boost/container_hash/hash.hpp,line=131,col=33::
                          no template named 'unary_function' in namespace 'std'; did you mean '__unary_function'?
    [21:48:49]: ▸         struct hash_base : std::unary_function<T, std::size_t> {};
    [21:48:49]: ▸                            ~~~~~^~~~~~~~~~~~~~

    Once we leap upgrades in React Native itself, these changes can be unblocked. Last year work was started on master...drew/react-native-72-4 which stalled out due to react-native-reanimated incompatibilities for RN/iOS noted in 5b678e0

    I think the compat is resolved in reanimated v3+ but what that means is more unknown compat upgrades for our other deps and then eventually react-native@73.

@drewvolz
Copy link
Member Author

drewvolz commented Mar 3, 2024

Since we do not run detox on nightlies, I've added a skip check for detox. ci/skip-detox label on PRs should bypass those failing provisioning checks for things we'd like to continue to check on nightlies and get into the main branch.

@drewvolz drewvolz added the ci/skip-detox bypass issues with detox or code signing label Mar 3, 2024
@drewvolz drewvolz added github_actions Pull requests that update GitHub Actions code area/ci Issues and PRs pertaining to CI status/pending rn upgrade labels Mar 3, 2024
@drewvolz drewvolz added this pull request to the merge queue Mar 3, 2024
Merged via the queue into master with commit c23e9c0 Mar 3, 2024
22 checks passed
@drewvolz drewvolz deleted the drew/xcode-15 branch March 3, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues and PRs pertaining to CI ci/skip-detox bypass issues with detox or code signing github_actions Pull requests that update GitHub Actions code status/pending rn upgrade
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants