-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixup github check annotations #7208
Merged
drewvolz
merged 9 commits into
master
from
drew/fix-unchanged-files-with-check-annotations
Sep 8, 2024
Merged
fixup github check annotations #7208
drewvolz
merged 9 commits into
master
from
drew/fix-unchanged-files-with-check-annotations
Sep 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rye
approved these changes
Sep 7, 2024
hawkrives
approved these changes
Sep 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7208 +/- ##
==========================================
- Coverage 12.55% 12.54% -0.02%
==========================================
Files 309 309
Lines 5280 5287 +7
Branches 1416 1416
==========================================
Hits 663 663
- Misses 4590 4597 +7
Partials 27 27 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up annotations that GitHub was flagging on every pull request for unchanged linting issues.
We can validate these are fixed by checking that the diff looks good, and that the annotations are not added in the checks/files changed tabs.