Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup github check annotations #7208

Merged
merged 9 commits into from
Sep 8, 2024

Conversation

drewvolz
Copy link
Member

@drewvolz drewvolz commented Sep 7, 2024

Cleans up annotations that GitHub was flagging on every pull request for unchanged linting issues.

We can validate these are fixed by checking that the diff looks good, and that the annotations are not added in the checks/files changed tabs.

@drewvolz drewvolz added the ci/skip-detox bypass issues with detox or code signing label Sep 7, 2024
@drewvolz drewvolz marked this pull request as draft September 7, 2024 20:16
@drewvolz drewvolz marked this pull request as ready for review September 7, 2024 23:56
Copy link

codecov bot commented Sep 7, 2024

Codecov Report

Attention: Patch coverage is 7.84314% with 94 lines in your changes missing coverage. Please review.

Project coverage is 12.54%. Comparing base (d35102f) to head (6ea5623).
Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7208      +/-   ##
==========================================
- Coverage   12.55%   12.54%   -0.02%     
==========================================
  Files         309      309              
  Lines        5280     5287       +7     
  Branches     1416     1416              
==========================================
  Hits          663      663              
- Misses       4590     4597       +7     
  Partials       27       27              

@drewvolz drewvolz merged commit dbe5ebf into master Sep 8, 2024
20 of 22 checks passed
@drewvolz drewvolz deleted the drew/fix-unchanged-files-with-check-annotations branch September 8, 2024 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/skip-detox bypass issues with detox or code signing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants