forked from ros-controls/ros2_controllers
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admittance robot description param #22
Open
destogl
wants to merge
37
commits into
master
Choose a base branch
from
admittance-robot-description-param
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
destogl
commented
Aug 1, 2024
admittance_controller/include/admittance_controller/admittance_rule_impl.hpp
Outdated
Show resolved
Hide resolved
Nibanovic
force-pushed
the
admittance-robot-description-param
branch
from
August 1, 2024 12:11
0b25655
to
fce1e28
Compare
Refactored Main changes:
Note:Please comment on this |
livanov93
reviewed
Aug 2, 2024
Comment on lines
+431
to
+441
/* some flag that determines whether we call the update() with goal_pose or with joint reference. | ||
How can we know here whether the reference was updated from subscribers or from itnerfaces? | ||
|
||
if(updated_from_subscribers) | ||
admittance_->update(joint_state_, ft_values_, *goal_pose_msg_, period, reference_admittance_); | ||
else | ||
admittance_->update(joint_state_, ft_values_, reference_, period, reference_admittance_); | ||
|
||
*/ | ||
|
||
admittance_->update(joint_state_, ft_values_, *goal_pose_msg_, period, reference_admittance_); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Nibanovic via parmeter maybe?
…gure to improve real-time performance (ros-controls#1269)
Co-authored-by: christophfroehlich <[email protected]>
…Robotics-forks/ros2_controllers into admittance-robot-description-param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributions via pull requests are much appreciated. Before sending us a pull request, please ensure that:
To send us a pull request, please:
colcon test
andpre-commit run
(requires you to install pre-commit bypip3 install pre-commit
)