Skip to content

Commit

Permalink
Update readme.md
Browse files Browse the repository at this point in the history
  • Loading branch information
mgrinko authored Oct 10, 2023
1 parent abb03e0 commit e788d17
Showing 1 changed file with 21 additions and 22 deletions.
43 changes: 21 additions & 22 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,38 +5,37 @@ Replace `<your_account>` with your Github username and copy the links to Pull Re

> Follow [these instructions](https://mate-academy.github.io/layout_task-guideline/#how-to-solve-the-layout-tasks-on-github)
## ❗️❗️❗️ DON'T FORGET TO PROOFREAD YOUR CODE WITH [CHECKLIST](https://github.com/mate-academy/layout_moyo-header/blob/master/checklist.md) BEFORE SENDING YOUR PULL REQUEST❗️❗️❗️

## The task
Create HTML page with the header using `flexbox` basing on [this mockup](https://www.figma.com/file/1sog2rmfyCjnVxkeZ3ptnc/MOYO-%2F-Header?node-id=0%3A1).

The page should match the design Pixel Perfect: all the sizes, colors and distanced MUST be the same as on the design.

### Requirements:
- pay attention the mock is adaptive. Develop the layout to fit on 1024px and 1200px the same as on the mock.
- reset browser default margins
- use semantic tags: `<header>`, `<img>`, `<nav>`, `<ul>`, `<li>` and `<a>`
- use images from [src/images](src/images)
- use semantic tags: `<header>`, `<nav>`, `ul`
- change links styles on `:hover`
- follow styles from the mock
- the link with `blue` color and line below is an active link. It should have `class="is-active"` and relevant styles.
- the link with only `blue` color is an example of `:hover` styles. Every link in the row should have `blue` color on `:hover`.
- add `data-qa="hover"` attribute to the 4th link for testing (`Laptops & computers`)
---
--> [CHECKLIST](https://github.com/mate-academy/layout_moyo-header/blob/master/checklist.md)
- reset browser default margins.
- Use [Roboto font](https://fonts.google.com/specimen/Roboto)
- the header should stretch the full page width
- the height should be set for nav links (not the header), take it from the design.
- header content should be vertically centered.
- Logo should also be a link with an image inside. But it should not be a part of the `<nav>`.
- ❗️ the blue link with a line below should have a class `is-active` in addition to any other classes you add.
- link color should be changed on `:hover`
- ❗️ add `data-qa="hover"` attribute to the 4th link for testing (`Laptops & computers`)
- Use the `::after` and position it relative to a link with `is-active` class

### Tips & Hints
- Check one more time if you added `data-qa="hover"` and `class="is-active"` required for tests
- Don't use `gap` property for indents. It's not supported in tests, use `margin` instead.
- Check one more time if you added `data-qa="hover"` and `class="is-active"`
required for tests
- Do not use `tabs`. Use `2 spaces` for indentation.
- Don't use repeated styles.
- There should not be margins before the first and after the last list items
- Use `2 spaces` for indentation in your file (not a `tab` character).
- Don't just copy all styles from Figma. Think, which of them are relevant.
Uneven sizes (e.g. `line-height: 14.6px`) are definitely useless.
- Don't use extra elements for blue line. Figure out how to work with `::after`
and positioning
- Check font styles. Use [google fonts](https://fonts.google.com/)
- Links in `nav` should have clickable area above and below the text
- Nav Links should not have any padding, but have text centered
- Uppercase letters for `nav__list` are made with styles, not hardcoded into
html (you should have usual text with first uppercase letter in html)
- Don't set height for `header` explicitly. Let the content (links) dictate it.
- Logo should also be a link to the main page of the website (#home). But it
should not be part of `nav`.


## ❗️❗️❗️ DON'T FORGET TO PROOFREAD YOUR CODE WITH [CHECKLIST](https://github.com/mate-academy/layout_moyo-header/blob/master/checklist.md) BEFORE SENDING YOUR PULL REQUEST❗️❗️❗️

0 comments on commit e788d17

Please sign in to comment.