Skip to content

Commit

Permalink
[PHP 8.4] Fix: Curl CURLOPT_BINARYTRANSFER deprecated
Browse files Browse the repository at this point in the history
The `CURLOPT_BINARYTRANSFER` PHP constant from the Curl extension was no-op since
PHP 5.1, and is deprecated in PHP 8.4. This removes the constant usage to avoid
the deprecation notice in PHP 8.4 and later.

Because this constant was no-op since PHP 5.1 (circa 2005), this change has no
impact.

See:

 - [PHP.Watch - PHP 8.4 - Curl: CURLOPT_BINARYTRANSFER deprecated](https://php.watch/versions/8.4/CURLOPT_BINARYTRANSFER-deprecated)
 - [commit](php/php-src@fc16285)
  • Loading branch information
Ayesh committed Jan 16, 2024
1 parent 594a08f commit 3df8f94
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion php/elFinder.class.php
Original file line number Diff line number Diff line change
Expand Up @@ -2706,7 +2706,6 @@ protected function curl_get_contents(&$url, $timeout, $redirect_max, $ua, $outfp
curl_setopt($ch, CURLOPT_FILE, $outfp);
} else {
curl_setopt($ch, CURLOPT_RETURNTRANSFER, true);
curl_setopt($ch, CURLOPT_BINARYTRANSFER, true);
}
curl_setopt($ch, CURLOPT_LOW_SPEED_LIMIT, 1);
curl_setopt($ch, CURLOPT_LOW_SPEED_TIME, $timeout);
Expand Down

0 comments on commit 3df8f94

Please sign in to comment.