-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DRY-refactored archive method in ArchivableRepository #676
Merged
gorskyolga
merged 6 commits into
develop
from
fix/refactor-archive-method-to-satisfy-dry
Sep 25, 2024
Merged
DRY-refactored archive method in ArchivableRepository #676
gorskyolga
merged 6 commits into
develop
from
fix/refactor-archive-method-to-satisfy-dry
Sep 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StriderDunedain
temporarily deployed
to
healthcheck
September 5, 2024 18:57
— with
GitHub Actions
Inactive
Мне кажется, можно просто удалить метод archive из TaskRepository.
|
StriderDunedain
temporarily deployed
to
healthcheck
September 20, 2024 05:09
— with
GitHub Actions
Inactive
StriderDunedain
had a problem deploying
to
healthcheck
September 20, 2024 19:08
— with
GitHub Actions
Failure
gorskyolga
temporarily deployed
to
healthcheck
September 20, 2024 19:22
— with
GitHub Actions
Inactive
gorskyolga
temporarily deployed
to
healthcheck
September 22, 2024 19:16
— with
GitHub Actions
Inactive
@Xalgina , Здесь нужно протестировать, что архивация через эндпоинты, осталась корректной: |
gorskyolga
temporarily deployed
to
healthcheck
September 24, 2024 19:06
— with
GitHub Actions
Inactive
Xalgina
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Протестировано, ок.
gorskyolga
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Что сделано?
Немного поправил реализацию метода
.archive
, стало попрощеЧто сейчас?
Жду ревью