Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding terraform support for metric anomaly monitors #698

Merged
merged 2 commits into from
Oct 25, 2024
Merged

Adding terraform support for metric anomaly monitors #698

merged 2 commits into from
Oct 25, 2024

Conversation

Andrew-L-Johnson
Copy link
Collaborator

As title says, adding terraform support for metric anomaly monitors.

To test, I ran:
go test -v -run TestAccSumologicMonitorsLibraryMonitor_create_all_monitor_types

sumovishal
sumovishal approved these changes Oct 24, 2024
View reviewed changes
Copy link
Collaborator

@sumovishal sumovishal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we should refactor some of shared code b/w Logs and Metrics Anomaly monitors later.

sumologic/resource_sumologic_monitors_library_monitor.go Show resolved Hide resolved
@Andrew-L-Johnson Andrew-L-Johnson merged commit 7e8b376 into master Oct 25, 2024
7 checks passed
@Andrew-L-Johnson Andrew-L-Johnson deleted the terraform-support-for-metric-anomaly-monitors branch October 25, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sumovishal sumovishal sumovishal approved these changes

Assignees
No one assigned
Labels
alerting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Andrew-L-Johnson @sumovishal