Pr to inquiry v2 #121

pavankumar0408 · 2023-12-12T11:58:41Z

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Type of change

Please choose appropriate options.

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to not work as expected)
This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes in the below checkboxes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Ran Test A
Ran Test B

Test Configuration:

Software versions:
Hardware versions:

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules

…d-inQuiry/editor into pr-to-inquiry-v2

rajnishdargan · 2023-12-27T09:39:29Z

projects/questionset-editor-library/src/lib/components/meta-form/meta-form.component.ts

@@ -214,7 +214,7 @@ export class MetaFormComponent implements OnChanges, OnDestroy {
          field.default = _.get(metaDataFields, 'recordedBy') !== 'Self' ? 'Yes' : 'No' ;
        }
        if (field.code === 'mode') {
-          field.default = _.get(metaDataFields, 'eval.mode')
+          field.default = _.get(metaDataFields, 'evalMode') == this.configService.editorConfig.evalMode || _.get(metaDataFields, 'mode') === true ? true : false;


@pavankumar0408 Instead of field.code === 'mode' can we use different name for this field say serverMode.
Editor config have a mode property and it's creating confusion at a first look what this mode is. Please provide a meaningful name to this field.

done changed to serverMode

rajnishdargan · 2023-12-27T09:44:58Z

projects/questionset-editor-library/src/lib/components/question/question.component.ts

@@ -1007,7 +1007,9 @@ export class QuestionComponent implements OnInit, AfterViewInit, OnDestroy {
    this.editorService.data = {};
    this.editorService.selectedSection = selectedUnitId;
    let metaData = this.getQuestionMetadata();
-    metaData.eval = activeNode?.data.metadata?.eval || data?.data?.eval;
+    if(activeNode?.data.metadata?.evalMode || data?.data?.evalMode || data?.data?.metadata?.evalMode){


I think this can be refactored:
Can you try below code for it -

const evalMode = activeNode?.data?.metadata?.evalMode || data?.data?.evalMode || data?.data?.metadata?.evalMode; if (evalMode) { metaData.evalMode = evalMode; }

And can you tell me why we are checking evalMode in all these place

rajnishdargan · 2023-12-27T09:50:11Z

projects/questionset-editor-library/src/lib/services/config/editor.config.json

-    "serverSearch": "{\"mode\":\"server\"}",
-    "clientSearch": "{\"mode\":\"client\"}",
+    "evalMode": "server",
+    "client": "client",


Are these these properties getting used any where?

"client": "client", "serverMode": "yes", "notServerMode": "no",

If not used please remove it.

rajnishdargan · 2023-12-27T09:54:23Z

projects/questionset-editor-library/src/lib/services/tree/tree.service.spec.data.ts

@@ -6,6 +6,7 @@ export const treeNode = {
        "keywords": [
            "test"
        ],
+        "mode": true,


Note: mode should be renamed to meaningful name.

Are we storing both mode and evalMode in question/questionset metadata for enabling server side evaluation ?

done. We are storing evalMode for server side evaluation

rajnishdargan · 2023-12-27T10:11:10Z

projects/questionset-editor-library/src/lib/components/editor/editor.component.ts

@@ -552,7 +552,9 @@ export class EditorComponent implements OnInit, OnDestroy, AfterViewInit {
          searchFormConfig:  this.questionlibraryInput.searchFormConfig,
          metadataFormConfig: this.questionlibraryInput.metadataFormConfig
        };
-        this.questionlibraryInput.collection.eval = this.treeService.getEval();
+        if(this.treeService.getEval()) {


Instead of taking this value from tree object can you set the evalMode in editorConfig take it from editorConfig ?
I have doubt here calling treeService will give error for Question Editor flow

This code is only for sending evalMode property to the resource library for composite search. Here, we are not making use of this inside editor just we are passing the configuration to library this will not break anything in editor flow.
@rajnishdargan

rajnishdargan · 2023-12-27T10:18:37Z

projects/questionset-editor-library/src/lib/services/tree/tree.service.ts

@@ -253,35 +253,40 @@ export class TreeService {
  }

  updateEvaluable(nodeId){


The method call of updateEvaluable in this service can you call it based on some condition check

Inside the method we have condition based update for evalMode. If I keep outside this will requires more changes and testing now.
@rajnishdargan

pavankumar0408 · 2024-01-04T13:41:32Z

@rajnishdargan, sonar issue fixed

sonarcloud · 2024-01-22T13:30:54Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
81.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

pavankumar0408 · 2024-02-13T08:18:39Z

Another PR has been raised

pavankumar0408 added 7 commits December 7, 2023 13:42

eval mode property changes

d225e0f

While adding questions added evalMode

ab8a301

select and unselect case fix

1f6fa6f

checkbox selection retain issue fixed

cdbc3e0

test cases updated

189ca99

Merge branch 'release-7.0.0_for_compass' of https://github.com/Sunbir…

bb5883e

…d-inQuiry/editor into pr-to-inquiry-v2

removed incomplete testcase

aa70284

rajnishdargan changed the base branch from release-7.0.0_for_compass to release-7.0.0 December 19, 2023 05:08

rajnishdargan changed the base branch from release-7.0.0 to release-7.0.0_for_compass December 19, 2023 05:12

rajnishdargan reviewed Dec 27, 2023

View reviewed changes

PR comments changes

eb7163a

rajnishdargan changed the base branch from release-7.0.0_for_compass to release-7.1.0-dev December 28, 2023 09:03

rajnishdargan changed the base branch from release-7.1.0-dev to release-7.0.0 December 28, 2023 09:04

rajnishdargan changed the base branch from release-7.0.0 to release-7.0.0_for_compass January 3, 2024 09:07

rajnishdargan changed the base branch from release-7.0.0_for_compass to release-7.0.0 January 3, 2024 11:36

rajnishdargan changed the base branch from release-7.0.0 to release-7.0.0_for_compass January 3, 2024 11:37

sonar issue fixes

f280365

pavankumar0408 added 3 commits January 22, 2024 09:59

sonar cube test coverage

7224de1

sonar test coverage

739acab

sonar cube test coverage

6969508

rajnishdargan changed the base branch from release-7.0.0_for_compass to release-7.1.0-dev January 22, 2024 09:21

rajnishdargan changed the base branch from release-7.1.0-dev to release-7.0.0_for_compass January 22, 2024 09:22

pavankumar0408 added 2 commits January 22, 2024 15:17

sonar cube code coverage

8cac0b9

sonar cube test coverage

704e81c

pavankumar0408 closed this Feb 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pr to inquiry v2 #121

Pr to inquiry v2 #121

pavankumar0408 commented Dec 12, 2023

rajnishdargan Dec 27, 2023

pavankumar0408 Dec 28, 2023

rajnishdargan Dec 27, 2023 •

edited

Loading

pavankumar0408 Dec 28, 2023

rajnishdargan Dec 27, 2023

pavankumar0408 Dec 28, 2023

rajnishdargan Dec 27, 2023 •

edited

Loading

pavankumar0408 Dec 28, 2023

rajnishdargan Dec 27, 2023

pavankumar0408 Dec 28, 2023

rajnishdargan Dec 27, 2023

pavankumar0408 Dec 28, 2023

pavankumar0408 commented Jan 4, 2024

sonarcloud bot commented Jan 22, 2024

pavankumar0408 commented Feb 13, 2024

		@@ -253,35 +253,40 @@ export class TreeService {
		}

		updateEvaluable(nodeId){

Pr to inquiry v2 #121

Pr to inquiry v2 #121

Conversation

pavankumar0408 commented Dec 12, 2023

Type of change

How Has This Been Tested?

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rajnishdargan Dec 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rajnishdargan Dec 27, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pavankumar0408 commented Jan 4, 2024

sonarcloud bot commented Jan 22, 2024

Quality Gate passed

pavankumar0408 commented Feb 13, 2024

rajnishdargan Dec 27, 2023 •

edited

Loading

rajnishdargan Dec 27, 2023 •

edited

Loading