-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementing text language Translation #12
Conversation
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
7962162 | Bearer Token | 2d2c823 | app/inference_services/base.py | View secret |
7962162 | Bearer Token | 3f84d2a | app/inference_services/base.py | View secret |
7962162 | Bearer Token | db88236 | app/inference_services/base.py | View secret |
7962162 | Bearer Token | 1755c9b | app/inference_services/base.py | View secret |
7962162 | Bearer Token | 3f84d2a | app/inference_services/base.py | View secret |
7962162 | Bearer Token | 0e2436b | app/inference_services/base.py | View secret |
7962162 | Bearer Token | 26a3707 | app/inference_services/base.py | View secret |
7962162 | Bearer Token | 58e2d05 | app/inference_services/base.py | View secret |
7962162 | Bearer Token | c26537f | app/inference_services/base.py | View secret |
7962162 | Bearer Token | dd9ba60 | app/inference_services/base.py | View secret |
7962162 | Bearer Token | a481aa3 | app/inference_services/base.py | View secret |
7962162 | Bearer Token | 45c939c | app/inference_services/base.py | View secret |
7962162 | Bearer Token | 45c939c | app/inference_services/base.py | View secret |
7962162 | Bearer Token | b0f1dec | app/inference_services/base.py | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
…ext-translation # Conflicts: # app/api.py # app/inference_services/base.py # app/inference_services/translate.py # app/schemas/tasks.py # requirements.txt
@cmplx-xyttmt the pytest is failing because it cant cinnect to higging_face But basically am done. I will comment out those tests |
I had an issue with the test of which the last 2 were about the version of python and sklearn. Please Review |
Don't comment them out. There's a way of accessing environment variables on Github. A better solution is to us e pytest mocking which you can read about here: https://pytest-with-eric.com/pytest-advanced/pytest-mocking/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merging, but some with some issues to note:
- Use
response.json()
instead ofresponse.text
to extract the translation from the response. - No need for
time.sleep
since you're already using exponential backoff.
No description provided.