Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GLMakie precompiles on Julia 1.11.2 #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support GLMakie precompiles on Julia 1.11.2 #329

wants to merge 1 commit into from

Conversation

kbarros
Copy link
Member

@kbarros kbarros commented Nov 5, 2024

The extension module GLMakiePrecompilesExt aims to precompile plotting functions for the GLMakie backend. The plotting functions themselves, however, are defined in a different extension module, PlottingExt, which is agnostic to Makie backend. This setup accidentally broke in Julia 1.11.1, which disallowed dependencies between extension modules. Hopefully there will be a solution in Julia 1.11.2, as per JuliaLang/julia#56204 (comment).

This PR makes the dependencies of GLMakiePrecompilesExt a strict superset of the dependencies of PlottingExt, so that it is safe to make GLMakiePrecompilesExt depend on PlottingExt. Enabled by JuliaLang/julia#56368, which has now been backported to 1.11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant