Update collision.cpp #3096
Open
Update collision.cpp #3096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix ceiling slope hang so which was fixed by others too.However,Ensure that the code is consistent in determining the validity of the p1 coordinate relative to the area range
|
@SuperTux/developers I'm not too familiar with our collision system. Will changing rdelta negatively affect anything else? |
This time, the depth detection logic has been modified to reduce the offset value appropriately so that the player can move more smoothly when close to the ceiling Also, adjusted the constraints to add additional handling of top collisions to make sure players don't stay in the ceiling area Hope this time everything will be fine
|
I reworked it and was able to implement it locally, so hopefully it will be useful for the main supertux branch! |
|
okay, so. this pr works... but not really. it makes it less common? but it still happens. |
|
i'll hold off on approving until it's fully fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix ceiling slope hang so which was fixed by others too.However,Ensure that the code is consistent in determining the validity of the p1 coordinate relative to the area range