Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPROVEMENT] added Musixmatch lyrics source #2683

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

martinmake
Copy link

@martinmake martinmake commented Nov 20, 2020

Please prefix your pull request with one of the following: [FEATURE] [FIX] [IMPROVEMENT].

In raising this pull request, I confirm the following (please check boxes):

  • I have read and understood the contributors guide.
  • I have checked that another pull request for this purpose does not exist.
  • I have considered, and confirmed that this submission will be valuable to others.
  • I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  • I give this submission freely, and claim no ownership to its content.

My familiarity with the project is as follows (check one):

  • I have never used the project.
  • I have used the project briefly.
  • I have used the project extensively, but have not contributed previously.
  • I am an active contributor to the project.

Implements #2682

@pep8speaks
Copy link

pep8speaks commented Nov 20, 2020

Hello @martinmake! Thanks for updating this PR.

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2020-11-20 15:59:01 UTC

@martinmake martinmake changed the title added Musixmatch lyrics source [IMPROVEMENT] added Musixmatch lyrics source Nov 20, 2020
@codecov
Copy link

codecov bot commented Nov 20, 2020

Codecov Report

Merging #2683 (34d2b6e) into master (bd46b35) will decrease coverage by 6.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2683      +/-   ##
==========================================
- Coverage   96.90%   90.86%   -6.04%     
==========================================
  Files           3        3              
  Lines         194      219      +25     
  Branches       21       24       +3     
==========================================
+ Hits          188      199      +11     
- Misses          5       17      +12     
- Partials        1        3       +2     
Impacted Files Coverage Δ
swaglyrics/cli.py 80.76% <66.66%> (-11.64%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd46b35...34d2b6e. Read the comment docs.

Copy link

@Mondonno Mondonno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good optimalization :) Maybe i change this soon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants