Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed Theme enum #35

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Renamed Theme enum #35

wants to merge 6 commits into from

Conversation

PatrickNegretto
Copy link

Renamed Theme enum in SMTheme, could result a duplication with other lib or app classes

@wtmoose
Copy link
Member

wtmoose commented Nov 9, 2016

Thanks for bringing this up. Normally, you'd be able to do SwiftMessages.Theme, but I made the unfortunate choice of also naming a class SwiftMessages.

I will address this, but it is going on the back burner for now because it is a breaking change. I will most likely rename the SwiftMessages class because I'm not a fan of using prefixes for disambiguation.

@Coeur
Copy link
Contributor

Coeur commented Mar 29, 2019

@wtmoose maybe renaming the class to SwiftMessage (without s at the end)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants