Move refreshCheckout out of db transaction #2379
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should address our analysis hangs. There is perhaps an issue upstream how db transactions are being handled in
FluentKit
andconsole-kit
should perhaps not hang (reported here) but with this in place I believe we'll get rid of the service hangs that require manual intervention.This has become more frequent recently, and I believe the reason is simply that we're seeing more new packages being added, which leads to a higher chance of a checkout (+ update work) taking us across the 10s event loop timeout.
Fixes #2227