Analysis updates #2642
Merged
Analysis updates #2642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
finestructure
commented
Sep 25, 2023
| } catch { | ||
| throw error | ||
| guard try await Current.git.hasBranch(defaultBranch, cacheDir) else { | ||
| throw AppError.analysisError(package.model.id, "Default branch '\(defaultBranch)' does not exist in checkout") |
There was a problem hiding this comment.
Add a check to handle this particular error. We may want to do an audit where we throw anything that isn't an AppError without an id - or simply ensure we wrap them all before we run updatePackages.
|
Ad hoc deploying to dev to confirm that it moves the package forward |
daveverwer
approved these changes
Sep 25, 2023
|
This cleared the stuck package on dev, merging and deploying. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2639