Remove task group #2656
Merged
Remove task group #2656
+4
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveverwer
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I deployed this version to dev yesterday morning at 10:14 CET and there hasn't been a hang since. Previously there were constant hangs (within an hour of re-deploying or restarting analysis) so this is hopefully indication that this fixes the hangs.
It's hard to judge the performance impact, because analysis hasn't been running properly on dev for quite a while. However, just comparing to prod it doesn't look too bad (maybe a factor of 2 - but dev is a slower machine).
Given how often we lose analysis for hours when I'm not around to restart it this seems like a good trade-off even if it was taking twice as long for a full cycle.