Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom collections styling #3509

Merged
merged 17 commits into from
Dec 5, 2024
Merged

Custom collections styling #3509

merged 17 commits into from
Dec 5, 2024

Conversation

daveverwer
Copy link
Member

Here are two options for displaying custom collection membership for packages in the SSWG collections:

Screenshot 2024-11-19 at 14 53 04@2x

I’m using the badge property of the metadata to create the lozenge and then the name after that. Multiple collections are in a listPhrase. For the screenshot, I have manually adjusted the collection name to not include the letters “SSWG”. We’d need to adjust the PackageList JSON to make that permanent.

I thought I’d prefer the separate badge when I set out to design it, but it doesn’t look like a link and it didn’t fit well where I first wanted it to go, under the package title.

I think the list item is the way to go.

Here's an alternative on the lozenge:

Screenshot 2024-11-19 at 15 13 13@2x

Let me know which one the workgroup prefers.

@cla-bot cla-bot bot added the cla-signed label Nov 19, 2024
@daveverwer daveverwer marked this pull request as draft November 19, 2024 15:15
@daveverwer daveverwer force-pushed the custom-collections-styling branch 2 times, most recently from eef0d4e to 750acb4 Compare November 19, 2024 16:42
@finestructure
Copy link
Member

finestructure commented Nov 20, 2024

For the screenshot, I have manually adjusted the collection name to not include the letters “SSWG”. We’d need to adjust the PackageList JSON to make that permanent.

This looks great!

The only issue I see is that if we drop the "SSWG" from the name, we end up with "Graduated package collection" on the collection page:

Screenshot 2024-11-20 at 10 15 48

We can fix that by simply prefixing it with the badge there. Or should we replicate the lozenge?

Also, the breadcrumb - Home > Graduated - looks a bit odd. Not sure how to best fix that but I don't think that's a show-stopper.

@finestructure
Copy link
Member

Regarding the breadcrumb, that should read: Home> collections > [SSWG] Graduated. That's independent from this PR (except with respect to how we deal with the badge prefix). I'll deal with that separately.

@finestructure
Copy link
Member

FYI, I'll rebase this branch because the blog post one is based on this branch.

@daveverwer
Copy link
Member Author

Was there any feedback from the SSWG on this design? The metadata one would be my preference, did they agree?

@finestructure
Copy link
Member

They were happy with either, we mainly talked about the process to get the json files hosted tbh (this was on Nov 20).

@daveverwer
Copy link
Member Author

I'll wrap this up today then.

@finestructure finestructure force-pushed the custom-collections-styling branch from 1b9e115 to 8dc0940 Compare December 5, 2024 12:57
@daveverwer daveverwer marked this pull request as ready for review December 5, 2024 17:09
@daveverwer
Copy link
Member Author

daveverwer commented Dec 5, 2024

This is ready for a final review and can go live whenever. Maybe Monday?

@finestructure
Copy link
Member

Monday sounds good!

@finestructure finestructure merged commit 7fc8bec into main Dec 5, 2024
6 checks passed
@finestructure finestructure deleted the custom-collections-styling branch December 5, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants