-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom collections styling #3509
Conversation
eef0d4e
to
750acb4
Compare
Regarding the breadcrumb, that should read: Home> collections > [SSWG] Graduated. That's independent from this PR (except with respect to how we deal with the badge prefix). I'll deal with that separately. |
FYI, I'll rebase this branch because the blog post one is based on this branch. |
Was there any feedback from the SSWG on this design? The metadata one would be my preference, did they agree? |
They were happy with either, we mainly talked about the process to get the json files hosted tbh (this was on Nov 20). |
I'll wrap this up today then. |
… to the blog post.
1b9e115
to
8dc0940
Compare
…ogpost First rough draft of custom collections blog post
This is ready for a final review and can go live whenever. Maybe Monday? |
Monday sounds good! |
Here are two options for displaying custom collection membership for packages in the SSWG collections:
I’m using the
badge
property of the metadata to create the lozenge and then the name after that. Multiple collections are in alistPhrase
. For the screenshot, I have manually adjusted the collection name to not include the letters “SSWG”. We’d need to adjust the PackageList JSON to make that permanent.I thought I’d prefer the separate badge when I set out to design it, but it doesn’t look like a link and it didn’t fit well where I first wanted it to go, under the package title.
I think the list item is the way to go.
Here's an alternative on the lozenge:
Let me know which one the workgroup prefers.