Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ngrams constructor clash when word is constructor #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix ngrams constructor clash when word is constructor #2

wants to merge 1 commit into from

Conversation

preynal
Copy link

@preynal preynal commented Sep 5, 2016

When building ngrams from phrases with the word "constructor", I get unexpected behavior. This was because the dictionaries are created with var x = {}; which makes them inherit from the default object prototype with a constructor property. Creating an object with a null prototype Object.create(null); solves the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant