Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

addition of hindi for maintainer guide #2891

Closed
wants to merge 3 commits into from

Conversation

VIDYA1980
Copy link

This PR adds a Hindi translation of the Maintainer Guide, enhancing accessibility and inclusivity for Hindi-speaking contributors and maintainers.

Checklist

  • Added Hindi translations
    Thank you for your consideration!

Copy link
Collaborator

@TenTraicion TenTraicion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VIDYA1980, Hello there, thanks for your contribution. but this PR doesn't follow our project rule properly.

  • The file naming isn't according to our rules.
  • the codes mentioned in the guide shouldn't be translated
  • some links are broken
  • the file isn't properly translated according to our main Maintainers Guide
  • The translation isn't mentioned in the main Maintainers Guide

Note: Kindly follow the rules mentioned in Translation Guide properly. and make required changes. Thanks

@TenTraicion TenTraicion added the changes requested Contributor is requested to make the required changes label Sep 2, 2023
@TenTraicion TenTraicion mentioned this pull request Sep 2, 2023
Copy link
Collaborator

@TenTraicion TenTraicion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VIDYA1980 the file name should be: maintainer_guide.hin.md
also it needs some changes mentioned below:

Comment on lines 31 to +34
| [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) | [Japanese](maintainer_guide/maintainer_guide.jpn.md) |
| :---: | :---: | :---: | :---: | :---: |
| [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) |
[Hindi](maintainer_guide/maintainer_guide_hin.md)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) | [Japanese](maintainer_guide/maintainer_guide.jpn.md) |
| :---: | :---: | :---: | :---: | :---: |
| [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) |
[Hindi](maintainer_guide/maintainer_guide_hin.md)
| [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Hindi](maintainer_guide/maintainer_guide_hin.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) |
| :---: | :---: | :---: | :---: | :---: |
| [Japanese](maintainer_guide/maintainer_guide.jpn.md) | [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) |

Comment on lines 9 to +11
| [English](maintainer_guide.md) | [Bangla](translations/maintainer_guide/maintainer_guide.ben.md) | [German](translations/maintainer_guide/maintainer_guide.ger.md) | [Italian](translations/maintainer_guide/maintainer_guide.ita.md) | [Japanese](translations/maintainer_guide/maintainer_guide.jpn.md) |
| :---: | :---: | :---: | :---: | :---: |
| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) |

| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) |[Hindi](translations/maintainer_guide/maintainer_guide.hin.md)|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| [English](maintainer_guide.md) | [Bangla](translations/maintainer_guide/maintainer_guide.ben.md) | [German](translations/maintainer_guide/maintainer_guide.ger.md) | [Italian](translations/maintainer_guide/maintainer_guide.ita.md) | [Japanese](translations/maintainer_guide/maintainer_guide.jpn.md) |
| :---: | :---: | :---: | :---: | :---: |
| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) |
| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) |[Hindi](translations/maintainer_guide/maintainer_guide.hin.md)|
| [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Hindi](maintainer_guide/maintainer_guide_hin.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) |
| :---: | :---: | :---: | :---: | :---: |
| [Japanese](maintainer_guide/maintainer_guide.jpn.md) | [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) |

@@ -0,0 +1,61 @@
# अनुरक्षक की मार्गदर्शिका
यह मार्गदर्शिका उन लोगों के लिए है जो समुदाय के लिए परियोजना के प्रबंधन और रखरखाव में सहायता के लिए अनुरक्षक के रूप में परियोजना में शामिल होना चाहते हैं। (यह **पहली बार योगदान करने वालों** के लिए मार्गदर्शिका नहीं है)
## उद्देश्य
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Translate section is missing. You don't need to add the table, but add the translation section with other properties.

इस परियोजना को एक साथ आगे बढ़ाने में मदद करने के लिए हमसे जुड़ें। [Twitter] पर मुझसे संपर्क करें
(https://twitter.com/Syknapse)
और मुझे अपना GitHub उपयोगकर्ता नाम भेजें ताकि मैं आपको जोड़ सकूं। आप नीचे दिए गए बटन पर क्लिक करके भी हमारे Discord समुदाय में शामिल हो सकते हैं:
[![Discord](https://badgen.net/discord/online-members/tWkvS4ueVF?label=Join%20Our%20Discord%20Server&icon=discord)](https://discord.gg/tWkvS4ueVF 'Join our Discord server!')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there should be a line break before the badge

@VIDYA1980
Copy link
Author

VIDYA1980 commented Sep 3, 2023 via email

@TenTraicion
Copy link
Collaborator

Closing: The changes requested has not been fixed and it's been over 7 Days

Note: Kindly read the proper guidelines in our Translation Guide also it's related to the Issue: #2881

Thanks and Regards

@TenTraicion TenTraicion closed this Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Contributor is requested to make the required changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants