-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
addition of hindi for maintainer guide #2891
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VIDYA1980, Hello there, thanks for your contribution. but this PR doesn't follow our project rule properly.
- The file naming isn't according to our rules.
- the codes mentioned in the guide shouldn't be translated
- some links are broken
- the file isn't properly translated according to our main Maintainers Guide
- The translation isn't mentioned in the main Maintainers Guide
Note: Kindly follow the rules mentioned in Translation Guide properly. and make required changes. Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@VIDYA1980 the file name should be: maintainer_guide.hin.md
also it needs some changes mentioned below:
| [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) | [Japanese](maintainer_guide/maintainer_guide.jpn.md) | | ||
| :---: | :---: | :---: | :---: | :---: | | ||
| [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) | | ||
[Hindi](maintainer_guide/maintainer_guide_hin.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) | [Japanese](maintainer_guide/maintainer_guide.jpn.md) | | |
| :---: | :---: | :---: | :---: | :---: | | |
| [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) | | |
[Hindi](maintainer_guide/maintainer_guide_hin.md) | |
| [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Hindi](maintainer_guide/maintainer_guide_hin.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) | | |
| :---: | :---: | :---: | :---: | :---: | | |
| [Japanese](maintainer_guide/maintainer_guide.jpn.md) | [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) | |
| [English](maintainer_guide.md) | [Bangla](translations/maintainer_guide/maintainer_guide.ben.md) | [German](translations/maintainer_guide/maintainer_guide.ger.md) | [Italian](translations/maintainer_guide/maintainer_guide.ita.md) | [Japanese](translations/maintainer_guide/maintainer_guide.jpn.md) | | ||
| :---: | :---: | :---: | :---: | :---: | | ||
| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) | | ||
|
||
| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) |[Hindi](translations/maintainer_guide/maintainer_guide.hin.md)| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| [English](maintainer_guide.md) | [Bangla](translations/maintainer_guide/maintainer_guide.ben.md) | [German](translations/maintainer_guide/maintainer_guide.ger.md) | [Italian](translations/maintainer_guide/maintainer_guide.ita.md) | [Japanese](translations/maintainer_guide/maintainer_guide.jpn.md) | | |
| :---: | :---: | :---: | :---: | :---: | | |
| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) | | |
| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) |[Hindi](translations/maintainer_guide/maintainer_guide.hin.md)| | |
| [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Hindi](maintainer_guide/maintainer_guide_hin.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) | | |
| :---: | :---: | :---: | :---: | :---: | | |
| [Japanese](maintainer_guide/maintainer_guide.jpn.md) | [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) | |
@@ -0,0 +1,61 @@ | |||
# अनुरक्षक की मार्गदर्शिका | |||
यह मार्गदर्शिका उन लोगों के लिए है जो समुदाय के लिए परियोजना के प्रबंधन और रखरखाव में सहायता के लिए अनुरक्षक के रूप में परियोजना में शामिल होना चाहते हैं। (यह **पहली बार योगदान करने वालों** के लिए मार्गदर्शिका नहीं है) | |||
## उद्देश्य |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Translate section is missing. You don't need to add the table, but add the translation section with other properties.
इस परियोजना को एक साथ आगे बढ़ाने में मदद करने के लिए हमसे जुड़ें। [Twitter] पर मुझसे संपर्क करें | ||
(https://twitter.com/Syknapse) | ||
और मुझे अपना GitHub उपयोगकर्ता नाम भेजें ताकि मैं आपको जोड़ सकूं। आप नीचे दिए गए बटन पर क्लिक करके भी हमारे Discord समुदाय में शामिल हो सकते हैं: | ||
[![Discord](https://badgen.net/discord/online-members/tWkvS4ueVF?label=Join%20Our%20Discord%20Server&icon=discord)](https://discord.gg/tWkvS4ueVF 'Join our Discord server!') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be a line break before the badge
hey i have modified all the changes as requested kindly check and let me
know if anything else need to be changed ,I am beginner sorry for the
mistakes i have done previously
…On Sat, Sep 2, 2023 at 10:40 PM Mehedi Hasan ***@***.***> wrote:
***@***.**** requested changes on this pull request.
@VIDYA1980 <https://github.com/VIDYA1980> the file name should be:
maintainer_guide.hin.md
also it needs some changes mentioned below:
------------------------------
In translations/translation.md
<#2891 (comment)>
:
> | [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) | [Japanese](maintainer_guide/maintainer_guide.jpn.md) |
| :---: | :---: | :---: | :---: | :---: |
| [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) |
+[Hindi](maintainer_guide/maintainer_guide_hin.md)
⬇️ Suggested change
-| [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) | [Japanese](maintainer_guide/maintainer_guide.jpn.md) |
-| :---: | :---: | :---: | :---: | :---: |
-| [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) |
-[Hindi](maintainer_guide/maintainer_guide_hin.md)
+| [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Hindi](maintainer_guide/maintainer_guide_hin.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) |
+| :---: | :---: | :---: | :---: | :---: |
+| [Japanese](maintainer_guide/maintainer_guide.jpn.md) | [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) |
------------------------------
In maintainer_guide.md
<#2891 (comment)>
:
> | [English](maintainer_guide.md) | [Bangla](translations/maintainer_guide/maintainer_guide.ben.md) | [German](translations/maintainer_guide/maintainer_guide.ger.md) | [Italian](translations/maintainer_guide/maintainer_guide.ita.md) | [Japanese](translations/maintainer_guide/maintainer_guide.jpn.md) |
| :---: | :---: | :---: | :---: | :---: |
-| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) |
-
+| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) |[Hindi](translations/maintainer_guide/maintainer_guide.hin.md)|
⬇️ Suggested change
-| [English](maintainer_guide.md) | [Bangla](translations/maintainer_guide/maintainer_guide.ben.md) | [German](translations/maintainer_guide/maintainer_guide.ger.md) | [Italian](translations/maintainer_guide/maintainer_guide.ita.md) | [Japanese](translations/maintainer_guide/maintainer_guide.jpn.md) |
-| :---: | :---: | :---: | :---: | :---: |
-| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) |
-
-| [Portuguese](translations/maintainer_guide/maintainer_guide.por.md) | [Ukrainian](/translations/maintainer_guide/maintainer_guide.ukr.md) |[Hindi](translations/maintainer_guide/maintainer_guide.hin.md)|
+| [English](../maintainer_guide.md) | [Bangla](maintainer_guide/maintainer_guide.ben.md) | [German](maintainer_guide/maintainer_guide.ger.md) | [Hindi](maintainer_guide/maintainer_guide_hin.md) | [Italian](maintainer_guide/maintainer_guide.ita.md) |
+| :---: | :---: | :---: | :---: | :---: |
+| [Japanese](maintainer_guide/maintainer_guide.jpn.md) | [Portuguese](maintainer_guide/maintainer_guide.por.md) | [Ukrainian](maintainer_guide/maintainer_guide.ukr.md) |
------------------------------
In translations/maintainer_guide/maintainer_guide_hin.md
<#2891 (comment)>
:
> @@ -0,0 +1,61 @@
+# अनुरक्षक की मार्गदर्शिका
+यह मार्गदर्शिका उन लोगों के लिए है जो समुदाय के लिए परियोजना के प्रबंधन और रखरखाव में सहायता के लिए अनुरक्षक के रूप में परियोजना में शामिल होना चाहते हैं। (यह **पहली बार योगदान करने वालों** के लिए मार्गदर्शिका नहीं है)
+## उद्देश्य
The Translate section is missing. You don't need to add the table, but add
the translation section with other properties.
------------------------------
In translations/maintainer_guide/maintainer_guide_hin.md
<#2891 (comment)>
:
> +
+प्रोजेक्ट में यह सुनिश्चित करने के लिए प्रीटियर स्थापित किया गया है कि चाहे योगदानकर्ता पीआर कैसे भी सबमिट करे, स्टाइल गाइड लागू किया जाएगा। इस तरह से प्रोजेक्ट को हमेशा एक ही इंडेंटेशन और शैली के साथ बनाए रखा जाता है।
+यदि आप देखते हैं कि HTML फ़ाइल अस्त-व्यस्त दिख रही है, तो प्रोजेक्ट रूट में नीचे दिए गए कोड को चलाएँ।
+
+```js
+npx prettier --write index.html
+```
+इसे फ़ाइल को फ़ॉर्मेट करने का प्रयास करना चाहिए और यदि ऐसा नहीं हो पाता है तो यह आपको त्रुटियाँ दिखाएगा। कभी-कभी कोई गुम हुआ क्लोजिंग टैग या टूटा हुआ HTML गलती से मर्ज हो जाता है और यह उसे पहचानने और ठीक करने का एक अच्छा तरीका है।
+
+यदि आप कभी भी संदेह में हों, तो आप हमेशा पीआर में मेरा या अन्य अनुरक्षकों का उल्लेख कर सकते हैं या मुझे [Twitter] पर डीएम कर सकते हैं। (https://twitter.com/Syknapse).
+
+## हमसे जुड़ें
+इस परियोजना को एक साथ आगे बढ़ाने में मदद करने के लिए हमसे जुड़ें। [Twitter] पर मुझसे संपर्क करें
+(https://twitter.com/Syknapse)
+और मुझे अपना GitHub उपयोगकर्ता नाम भेजें ताकि मैं आपको जोड़ सकूं। आप नीचे दिए गए बटन पर क्लिक करके भी हमारे Discord समुदाय में शामिल हो सकते हैं:
+[![Discord](https://badgen.net/discord/online-members/tWkvS4ueVF?label=Join%20Our%20Discord%20Server&icon=discord)](https://discord.gg/tWkvS4ueVF 'Join our Discord server!')
there should be a line break before the badge
—
Reply to this email directly, view it on GitHub
<#2891 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AV5DHUM4SZSEMHNJRXR2YOLXYNR7LANCNFSM6AAAAAA4IVHJT4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
Closing: The changes requested has not been fixed and it's been over 7 Days Note: Kindly read the proper guidelines in our Translation Guide also it's related to the Issue: #2881 Thanks and Regards |
This PR adds a Hindi translation of the Maintainer Guide, enhancing accessibility and inclusivity for Hindi-speaking contributors and maintainers.
Checklist
Thank you for your consideration!