Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brynjar H's card #2943

Merged
merged 4 commits into from
Sep 21, 2023
Merged

Brynjar H's card #2943

merged 4 commits into from
Sep 21, 2023

Conversation

binnih
Copy link
Contributor

@binnih binnih commented Sep 16, 2023

Added my card to the index.html file.

Added my card
@ascodeasice ascodeasice self-assigned this Sep 16, 2023
@ascodeasice
Copy link
Collaborator

Hi, you should replace "Your handle" in line 129 and 131 with your username.
And also update the href field in line 138 and in other anchor tags.

I'll review this PR again after you've made changes, and help you merge it.

@ascodeasice ascodeasice added the changes requested Contributor is requested to make the required changes label Sep 16, 2023
Added correct handles where needed.
index.html Outdated Show resolved Hide resolved
@CandidDeer
Copy link
Collaborator

@binnih Please note that we will close any PRs with unresolved change requests 7 days after initial opening. Thx.

@ascodeasice ascodeasice merged commit 866b079 into Syknapse:master Sep 21, 2023
@ascodeasice
Copy link
Collaborator

Good job, I've merged your PR. You will be able to see your card on our website in a moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes requested Contributor is requested to make the required changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants