add Plutobby #2954
Merged
add Plutobby #2954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ascodeasice
reviewed
Sep 27, 2023
ascodeasice
added
the
changes requested
|
fixed
…On Wed, Sep 27, 2023 at 4:49 AM Leo Wang ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In index.html
<#2954 (comment)>
:
> + <i class="fab fa-twitter"></i>
+ <a href="https://www.twitter.com" target="_blank">twitter.com/ly_nxhyper</a>
+ <i class="fab fa-github"></i>
+ <a href="https://www.github.com" target="_blank">https://github.com/Plutobby</a>
Hi, you should put your account link inside the href field, and your
username between the tag like below.
So that the links shows your name and directs to your account's website.
You can update the PR by committing and pushing again.
⬇️ Suggested change
- <i class="fab fa-twitter"></i>
- <a href="https://www.twitter.com" target="_blank">twitter.com/ly_nxhyper</a>
- <i class="fab fa-github"></i>
- <a href="https://www.github.com" target="_blank">https://github.com/Plutobby</a>
+ <i class="fab fa-twitter"></i>
+ <a href="https://www.twitter.com/ly_nxhyper" target="_blank">ly_nxhyper (or your username)</a>
+ <i class="fab fa-github"></i>
+ <a href="https://www.github.com/Plutobby" target="_blank">Plutobby(or your username)</a>
—
Reply to this email directly, view it on GitHub
<#2954 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AURT3XEKVGFVE32DSCBVO3LX4OO5PANCNFSM6AAAAAA5HUUTIU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
|
Thank you for your contribution, your PR has been merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.