Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for snapgene files #114

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add support for snapgene files #114

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b46878
Add support for snapgene files
cjmyers Dec 18, 2019
8f1d4bc
Fixed typo
cjmyers Dec 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/conversion-form/html/form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,12 @@ <h3 class="panel-title">
<br />
</label>
</div>
<div class="radio">
<label>
<input type="radio" name="output" value="SnapGene" id="snapgene" /> Output SnapGene
<br />
</label>
</div>
<div class="radio">
<label>
<input type="radio" name="output" value="FASTA" id="fasta" /> Output FASTA
Expand Down
5 changes: 4 additions & 1 deletion src/conversion-form/js/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ function getOutputLanguage() {
var SBOL1 = document.getElementById("sbol11");
var SBOL2 = document.getElementById("sbol20");
var GFF3 = document.getElementById("gff3");
var SnapGene = document.getElementById("snapgene");
var GenBank = document.getElementById("genbank");
var FASTA = document.getElementById("fasta");

Expand All @@ -166,6 +167,8 @@ function getOutputLanguage() {
return "SBOL2";
} else if(GenBank.checked) {
return "GenBank";
} else if(SnapGene.checked) {
return "SnapGene";
} else if(FASTA.checked) {
return "FASTA";
} else if(GFF3.checked) {
Expand Down Expand Up @@ -193,7 +196,7 @@ function displayValidationResult(data, textStatus, jqXHR) {
var interpreted = parseData(data);
document.getElementById("result").innerHTML = interpreted.join("<br>");
document.getElementById("myModal").style.display = "block";
}
}v
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Syntax error here might be leading to issues.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Committed change, but I was actually not testing converter but rather validator when it was not working. Still suspect issue has to do with binary files.


function apiError(data, textStatus, jqXHR) {
console.log(data);
Expand Down
Binary file modified src/libSBOLj.jar
View file
Open in desktop
Binary file not shown.
6 changes: 6 additions & 0 deletions src/validation-form/html/form.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,12 @@ <h3 class="panel-title">
<br />
</label>
</div>
<div class="radio">
<label>
<input type="radio" name="output" value="SnapGene" id="snapgene" /> Output SnapGene
<br />
</label>
</div>
<div class="radio">
<label>
<input type="radio" name="output" value="FASTA" id="fasta" /> Output FASTA
Expand Down
3 changes: 3 additions & 0 deletions src/validation-form/js/scripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ function getOutputLanguage() {
var SBOL2 = document.getElementById("sbol20");
var GFF3 = document.getElementById("gff3");
var GenBank = document.getElementById("genbank");
var SnapGene = document.getElementById("snapgene");
var FASTA = document.getElementById("fasta");

if(SBOL1.checked) {
Expand All @@ -222,6 +223,8 @@ function getOutputLanguage() {
return "SBOL2";
} else if(GenBank.checked) {
return "GenBank";
} else if(SnapGene.checked) {
return "SnapGene";
} else if(FASTA.checked) {
return "FASTA";
} else if(GFF3.checked) {
Expand Down
2 changes: 2 additions & 0 deletions src/validator/validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,8 @@ def build(self, data):
self.output_file = self.output_file + ".rdf"
elif self.language == 'GFF3':
self.output_file = self.output_file + '.gff'
elif self.language == 'SnapGene':
self.output_file = self.output_file + '.dna'
elif self.language == 'GenBank':
self.output_file = self.output_file + '.gb'
else:
Expand Down