Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle None namespace and version suffix in conversion #285

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

handle None namespace and version suffix in conversion #285

wants to merge 7 commits into from

Commits on Sep 4, 2024

  1. handle None namespace and version suffix in conversion 

    Created a function that strips the end of the identity when converting to sbol3 in case it ends with the version number (as per the sbol2.3 specification)

Added this conversion to all implemented objects

Added roundtrip inclusion of sbol2version in the sbol2 identity. Defaults to "1"
    @fxbuson
    fxbuson committed Sep 4, 2024
    Configuration menu
    Copy the full SHA
    229573f View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2024

  1. fix rstrip misunderstanding 

    also properly determining identities in toplevel objects
    @fxbuson
    fxbuson committed Sep 5, 2024
    Configuration menu
    Copy the full SHA
    9c7306a View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2024

  1. handle case without sbol2 version 

    Co-authored-by: Jacob Beal <[email protected]>
    @fxbuson @jakebeal
    fxbuson and jakebeal authored Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3b41bbf View commit details
    Browse the repository at this point in the history

  2. check if sbol3 object has sbol2 version

    @fxbuson
    fxbuson committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    3664056 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'issue_283' of https://github.com/fxbuson/SBOL-utilities … 

    …into issue_283
    @fxbuson
    fxbuson committed Sep 27, 2024
    Configuration menu
    Copy the full SHA
    8e95d0d View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. update CI workflow 

    dropped python versions 3.7 and 3.8 (reaching EOL by the end of the year) and adding 3.12
    @fxbuson
    fxbuson committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    b44f9c8 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. add simplest pysbol2 CD test file 

    as described in issue 283
    @fxbuson
    fxbuson authored Nov 1, 2024
    Configuration menu
    Copy the full SHA
    77376a3 View commit details
    Browse the repository at this point in the history