348 allow sbol closure semantics #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 9, 2021 11:45
…re to sbol3:refersTo
…ure is not fully supported
Include the property name from the SHACL report so a user knows which property the message is about.
Add a simpler and self-contained test case to reproduce issue 48 for a single property.
Fix up some inline comments and add links to issues.
tcmitchell
approved these changes
Nov 12, 2021
There was a problem hiding this comment.
These changes all look good. I made some minor changes and a couple of additions:
- Fixed up inline comments in your unit tests to include links to issues
- Added a self-contained unit test that demonstrates the issue on a single property without the need of a 1,500 line file and 16 error messages. I retained your larger unit test as well.
- Improved the messages generated from the SHACL report so they indicate to which property the issue relates.
Cool! Thanks for the review and the improvements. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refersToproperty name, replacinghasFeatureTopLevelobjects which are not contained in aDocument