Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #437: visitor return values #440

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Fix #437: visitor return values #440

merged 3 commits into from
Oct 16, 2023

Conversation

jakebeal
Copy link
Contributor

@jakebeal jakebeal commented Oct 7, 2023

Fix #437 by returning the value computed by the visit functions in the visitor pattern.

Note that the read-the-docs test is expected to fail, as this doesn't have the fix pending in #438

@jakebeal jakebeal self-assigned this Oct 7, 2023
@tcmitchell
Copy link
Collaborator

I merged main to get the read-the-docs fix

@tcmitchell tcmitchell added this to the 1.2 milestone Oct 16, 2023
tcmitchell
tcmitchell approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@tcmitchell tcmitchell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stunning. Thanks for finding this and for fixing it!

@tcmitchell tcmitchell merged commit b19e64e into main Oct 16, 2023
22 checks passed
@tcmitchell tcmitchell deleted the 437-visitor-return-values branch October 16, 2023 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcmitchell tcmitchell tcmitchell approved these changes

Assignees

@jakebeal jakebeal

Labels
None yet
Projects
None yet
Milestone
1.2
Development

Successfully merging this pull request may close these issues.

Visitor functions do not actually return values
2 participants
@jakebeal @tcmitchell