Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fishnet: Removal as rewriten in Rust and require a new package #5216

Merged
merged 1 commit into from
Jun 1, 2022

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Apr 20, 2022

Description

Removal of fishnet package and dependency as it will require a totally new package since code was migrated to rust #5043 (comment)

Fixes #5043

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@th0ma7 th0ma7 self-assigned this Apr 20, 2022
@th0ma7
Copy link
Contributor Author

th0ma7 commented Apr 20, 2022

@mayweed are you good with its removal? Until a newer rust package gets created (if ever)?

@th0ma7 th0ma7 requested a review from hgy59 April 20, 2022 20:56
@hgy59
Copy link
Contributor

hgy59 commented Apr 25, 2022

I prefere not to remove packages for such a reason.
If the build fails, you could declare the package BROKEN and add respective information to the BROKEN file.
Otherwise it would be difficult to migrate to the rust version as former implementation is not visible anymore.

@th0ma7
Copy link
Contributor Author

th0ma7 commented Apr 27, 2022

@hgy59 I've looked at the current setup and if I get this right it is not even usable as it stands. This is even worst than broken.

A totally new package is needed to replace this one. In the meantime this is useless obsolete code for my standpoint.

@Safihre
Copy link
Contributor

Safihre commented Jun 1, 2022

I agree, let's remove this dead code.

@th0ma7 th0ma7 merged commit 4285c83 into SynoCommunity:master Jun 1, 2022
@th0ma7 th0ma7 deleted the fishnet-py310 branch June 1, 2022 11:14
@mayweed
Copy link
Contributor

mayweed commented Jun 1, 2022

@th0ma7 i think it’s better to remove that dead code, hope someone will find the time to write a mk for the new fishnet!
Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

META: Python 3.10 / 3.11 package status
4 participants