Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] bazarr: update 1.2.1 => 1.2.4 #5797

Closed
wants to merge 4 commits into from

Conversation

smaarn
Copy link
Contributor

@smaarn smaarn commented Jul 1, 2023

Description

Update bazarr 1.2.1 => 1.2.3

Notes:

  • Python 3.11 is not officially supported yet at the bazarr level (experimental support).
  • Python 3.11 can't be supported for old DSMs so if we are to provide with a Python 3.11 version that would be only for "recent" DSMs

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested

Type of change

  • Package update

@smaarn smaarn self-assigned this Jul 1, 2023
@smaarn smaarn marked this pull request as ready for review July 2, 2023 08:59
@th0ma7
Copy link
Contributor

th0ma7 commented Jul 3, 2023

Related to greenlet, you can upgrade to version 2.x although you will require:

# archs without C++11 support are not supported:
UNSUPPORTED_ARCHS = $(ARMv5_ARCHS) $(OLD_PPC_ARCHS)

# [greenlet]
ifeq ($(call version_lt, ${TC_GCC}, 5.0),1)
WHEELS_CPPFLAGS = [greenlet] -std=c++11
endif

OR you also can provide geenlet 1.x for GCC < 4.9, and -std=c++11 for GCC < 5.0 and using default for the remaining.

Python 3.10 and 3.11 are due for an update. I'll update that example accordingly so you can easily reuse as you see fit.

EDIT: Updated code snipet if that helps, where if GCC is of version 4.9.x it add -std=c++11 else uses older version of greenlet

# [greenlet]
ifeq ($(call version_ge, $(TC_GCC), 4.9),1)
WHEELS += src/requirements-crossenv-greenlet-v2.txt
ifeq ($(call version_lt, $(TC_GCC), 5.0),1)
WHEELS_CPPFLAGS += [greenlet] -std=c++11
endif
else
WHEELS += src/requirements-crossenv-greenlet-v1.txt
endif

@smaarn smaarn marked this pull request as draft July 11, 2023 20:51
@smaarn smaarn changed the title bazarr: update 1.2.1 => 1.2.2 [WIP] bazarr: update 1.2.1 => 1.2.3 Jul 11, 2023
@smaarn smaarn force-pushed the feat/bazarr/upgrade-1.2.2 branch from 5752308 to 5a373b6 Compare July 20, 2023 20:56
@smaarn smaarn changed the title [WIP] bazarr: update 1.2.1 => 1.2.3 [WIP] bazarr: update 1.2.1 => 1.2.4 Aug 27, 2023
@smaarn
Copy link
Contributor Author

smaarn commented Aug 27, 2023

Superseded by #5820

@smaarn smaarn closed this Aug 27, 2023
@smaarn smaarn deleted the feat/bazarr/upgrade-1.2.2 branch August 27, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants