Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

native-cmake.mk: Fix build whereas install wouldn't be probed #6235

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

th0ma7
Copy link
Contributor

@th0ma7 th0ma7 commented Sep 22, 2024

Description

native-cmake.mk: Fix build whereas install wouldn't be probed - When fixing native/libmysql to work with new debian image using legacy cmake, it was also converted to using ninja by default like cross-cmake. An re-ordering of the rule files was missing for it to work.

Fixes #6220 (comment)

Checklist

  • Build rule all-supported completed successfully
  • New installation of package completed successfully
  • Package upgrade completed successfully (Manually install the package again)
  • Package functionality was tested
  • Any needed documentation is updated/created

Type of change

  • Bug fix
  • New Package
  • Package update
  • Includes small framework changes
  • This change requires a documentation update (e.g. Wiki)

@th0ma7 th0ma7 self-assigned this Sep 22, 2024
@th0ma7 th0ma7 merged commit ef647d7 into SynoCommunity:master Sep 22, 2024
1 check passed
@th0ma7 th0ma7 deleted the sql-fix branch September 22, 2024 12:49
@th0ma7 th0ma7 mentioned this pull request Sep 22, 2024
6 tasks
@hgy59
Copy link
Contributor

hgy59 commented Sep 24, 2024

@th0ma7 thanks, unfortunately your comment "Fixes ..." triggered to close #6220 and I had to reopen it 😄

@hgy59
Copy link
Contributor

hgy59 commented Sep 24, 2024

Probably github has changed something, IMHO only issues where closed by such comments...

@th0ma7
Copy link
Contributor Author

th0ma7 commented Sep 24, 2024

Odd indeed...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants