fix: calculateFfactor if paxDB has taxID !4 digits #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR has been automatically tested with GH Actions. Here is the output of the tests:
|
|
I tested it by replacing all GECKO/tutorials/full_ecModel/protocol.m Line 213 in b512ea3 |
mihai-sysbio
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Thanks @edkerk for implementing the fix and also for testing it!
edkerk
added a commit
that referenced
this pull request
Dec 2, 2023
* fix: loadDatabases check for duplicate protIDs (#349) * fix: prevent NaN in light ecModels (#346) * fix: calculateFfactor if paxDB has taxID !4 chars (#347) * fix: runDLKcat if path has spaces (#352) * refactor: FSEOF (#356) * fix: FSEOF to 0.9 of teorethical max prod * refactor: switch force objetive to target * fix: remove unnecesary function * fix: update input arguments * fix: temporal solution k-score * refactor: FSEOF * feat: add gene essentiality to FSEOF * fix: file writing * feat: add cutoff based on quantile * feat: report target transport reactions * refactor: add cutoff for essentiality * fix: bug identifying gene essentiality * doc: move installations instructions to wiki (#357) * move installation instructions to wiki * GECKOInstaller checks for latest GECKO version * fix: prevent duplications in protein pseudometabolites * minor fixes * doc: update documentation * doc: swap gitter for GitHub Discussions * fix: correct link to upgrade instructions * fix: synchronize STEP numbers protocol and paper --------- Co-authored-by: Albert Tafur Rangel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
Instructions on merging this PR:
developas target branch, and will be resolved with a squash-merge.mainas target branch, and will be resolved with a merge commit.