-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: FSEOF #356
Merged
Merged
refactor: FSEOF #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR has been automatically tested with GH Actions. Here is the output of the tests:
|
edkerk
approved these changes
Oct 21, 2023
as suggested by @edkerk, gene essentially now is considered if growth is < 1e-8. |
edkerk
added a commit
that referenced
this pull request
Dec 2, 2023
* fix: loadDatabases check for duplicate protIDs (#349) * fix: prevent NaN in light ecModels (#346) * fix: calculateFfactor if paxDB has taxID !4 chars (#347) * fix: runDLKcat if path has spaces (#352) * refactor: FSEOF (#356) * fix: FSEOF to 0.9 of teorethical max prod * refactor: switch force objetive to target * fix: remove unnecesary function * fix: update input arguments * fix: temporal solution k-score * refactor: FSEOF * feat: add gene essentiality to FSEOF * fix: file writing * feat: add cutoff based on quantile * feat: report target transport reactions * refactor: add cutoff for essentiality * fix: bug identifying gene essentiality * doc: move installations instructions to wiki (#357) * move installation instructions to wiki * GECKOInstaller checks for latest GECKO version * fix: prevent duplications in protein pseudometabolites * minor fixes * doc: update documentation * doc: swap gitter for GitHub Discussions * fix: correct link to upgrade instructions * fix: synchronize STEP numbers protocol and paper --------- Co-authored-by: Albert Tafur Rangel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
FSEOF implementation in GECKO 2 in summary fix % of the maximum growth and forced the rest of the carbon source towards product target. Nevertheless, original implementation (https://doi.org/10.1128/AEM.00115-10), same as RAVEN have, is the opposite. A maximum theoretical product is calculated, then this value is fixed to a different % of it, to further maximize the growth. Then, here FSEOF implementation is refactored to follow same as RAVEN since the cell will always have growth as objective.
Now:
alpha (values to fix target production) vector from the minimum production to 90% of the maximum theoretical yield, in n steps defined by the user.
k_score (mean of fold changes) is not longer calculated, then an slope value is calculated for each reaction which always increase or decrease while enforcing the objective
Actions are suggested for reactions and gene targets. OE (ever expression) for those reaction that always increase; KD, for those that always decrease; KO, for those that always decrease but in the las step (90% of the maximum theoretical yield) are zero.
Transport reactions, defined as reactions involving (at least) one metabolite name in more than one compartment. are reported in a new table.
Gene targets predicted are checked for gene essentiality while maximizing growth and product target production.
Instructions on merging this PR:
develop
as target branch, and will be resolved with a squash-merge.main
as target branch, and will be resolved with a merge commit.