Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: FSEOF #356

Merged
merged 12 commits into from
Nov 29, 2023
Merged

refactor: FSEOF #356

merged 12 commits into from
Nov 29, 2023

Conversation

ae-tafur
Copy link
Collaborator

@ae-tafur ae-tafur commented Oct 3, 2023

Main improvements in this PR:

FSEOF implementation in GECKO 2 in summary fix % of the maximum growth and forced the rest of the carbon source towards product target. Nevertheless, original implementation (https://doi.org/10.1128/AEM.00115-10), same as RAVEN have, is the opposite. A maximum theoretical product is calculated, then this value is fixed to a different % of it, to further maximize the growth. Then, here FSEOF implementation is refactored to follow same as RAVEN since the cell will always have growth as objective.

Now:

  • alpha (values to fix target production) vector from the minimum production to 90% of the maximum theoretical yield, in n steps defined by the user.

  • k_score (mean of fold changes) is not longer calculated, then an slope value is calculated for each reaction which always increase or decrease while enforcing the objective

  • Actions are suggested for reactions and gene targets. OE (ever expression) for those reaction that always increase; KD, for those that always decrease; KO, for those that always decrease but in the las step (90% of the maximum theoretical yield) are zero.

  • Transport reactions, defined as reactions involving (at least) one metabolite name in more than one compartment. are reported in a new table.

  • Gene targets predicted are checked for gene essentiality while maximizing growth and product target production.

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

@ae-tafur ae-tafur requested a review from edkerk October 3, 2023 21:02
@ae-tafur ae-tafur changed the base branch from main to develop October 3, 2023 21:03
@github-actions
Copy link

github-actions bot commented Oct 3, 2023

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 
Running geckoCoreFunctionTests
Done geckoCoreFunctionTests
__________

Note: In the case of multiple test runs, this post will be edited.

@ae-tafur ae-tafur marked this pull request as ready for review October 11, 2023 17:17
@ae-tafur
Copy link
Collaborator Author

ae-tafur commented Oct 23, 2023

as suggested by @edkerk, gene essentially now is considered if growth is < 1e-8.

@edkerk edkerk merged commit f4a40b5 into develop Nov 29, 2023
1 check passed
@edkerk edkerk deleted the refactor/target_as_FSEOF branch November 29, 2023 09:49
@edkerk edkerk mentioned this pull request Nov 30, 2023
2 tasks
edkerk added a commit that referenced this pull request Dec 2, 2023
* fix: loadDatabases check for duplicate protIDs (#349)

* fix: prevent NaN in light ecModels (#346)

* fix: calculateFfactor if paxDB has taxID !4 chars (#347)

* fix: runDLKcat if path has spaces (#352)

* refactor: FSEOF (#356)

* fix: FSEOF to 0.9 of teorethical max prod

* refactor: switch force objetive to target

* fix: remove unnecesary function

* fix: update input arguments

* fix: temporal solution k-score

* refactor: FSEOF

* feat: add gene essentiality to FSEOF

* fix: file writing

* feat: add cutoff based on quantile

* feat: report target transport reactions

* refactor: add cutoff for essentiality

* fix: bug identifying gene essentiality

* doc: move installations instructions to wiki (#357)

* move installation instructions to wiki

* GECKOInstaller checks for latest GECKO version

* fix: prevent duplications in protein pseudometabolites

* minor fixes

* doc: update documentation

* doc: swap gitter for GitHub Discussions

* fix: correct link to upgrade instructions

* fix: synchronize STEP numbers  protocol and paper

---------

Co-authored-by: Albert Tafur Rangel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants