Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readYAMLmodel allows non-used genes #494

Merged
merged 2 commits into from
Jun 30, 2023
Merged

fix: readYAMLmodel allows non-used genes #494

merged 2 commits into from
Jun 30, 2023

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Jun 26, 2023

Main improvements in this PR:

  • fix:
    • readYAMLmodel allows for a model that has gene entries that are not present in any grRules: these are unused genes and should be allowed. This also prevents a bug where gene annotations are wrongly assigned.
    • writeYAMLmodel correct parsing of text to avoid escape characters (e.g. SMILES may contain \C).

I hereby confirm that I have:

  • Selected develop as a target branch

Allow for not all model.genes entries being in model.grRules.
@edkerk edkerk added this to the 2.8.3 milestone Jun 26, 2023
@github-actions
Copy link

github-actions bot commented Jun 26, 2023

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 > Installing from location             /home/m/actions-runner/_work/RAVEN/RAVEN
> Checking RAVEN release DEVELOPMENT
> Checking MATLAB release 2020b
> Checking system architecture glnxa64
> Set RAVEN in MATLAB path Pass
> Save MATLAB path Pass
> Make binaries executable Pass

> Add Java paths for Excel format Pass
> Checking libSBML version 5.19.0
> Checking model import and export
> Import Excel format Pass
> Export Excel format Pass
> Import SBML format Pass
> Export SBML format Pass

> Checking for LP solvers
Writing problem data to `outpb.lp'...
271 lines were written
> glpk Pass
> gurobi Pass
> soplex Fail
> cobra Pass
> Set RAVEN solver gurobi

> Checking BLAST+ Pass
> Checking DIAMOND Pass
> Checking HMMER Pass

> Checking function uniqueness Pass

*** checkInstallation complete ***

Running blastPlusTests
.
Done blastPlusTests

Running cdhitTests
.
Done cdhitTests

Running checkTasksTests
.
Done checkTasksTests

Running diamondTests
.
Done diamondTests

Running fillGapsLargeTests
..
Done fillGapsLargeTests

Running fillGapsSmallTests
...
Done fillGapsSmallTests

Running hmmerTests
.
Done hmmerTests

Running importExportTests
....
Done importExportTests

Running mafftTests
.
Done mafftTests

Running miriamTests
.
Done miriamTests

Running modelAbilitiesTests
........
Done modelAbilitiesTests

Running modelConversionTests
.
Done modelConversionTests

Running modelCurationTests
.......... ........
Done modelCurationTests

Running modelSortingTests
..
Done modelSortingTests

Running solverTests
..Writing problem data to `outpb.lp'...
271 lines were written

Error occurred in solverTests/testSoplex and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using solverTests>testSoplex (line 100)
Solver not working
..
Done solverTests

Running tinitTests
..........
Done tinitTests

Failure Summary:

Name Failed Incomplete Reason(s)
=======================================================
solverTests/testSoplex X X Errored.

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk merged commit 4db3072 into develop Jun 30, 2023
1 check passed
@edkerk edkerk deleted the fix/readYAMLmodel branch June 30, 2023 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant