Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: makeBinaryExecutable explicit filenames #528

Merged
merged 1 commit into from
Feb 24, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Feb 23, 2024

Main improvements in this PR:

I hereby confirm that I have:

  • Selected develop as a target branch

@edkerk edkerk added this to the 2.8.7 milestone Feb 23, 2024
Copy link

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 > Installing from location             /home/m/actions-runner/_work/RAVEN/RAVEN
> Checking RAVEN release DEVELOPMENT
> Checking MATLAB release 2020b
> Checking system architecture glnxa64
> Set RAVEN in MATLAB path Pass
> Save MATLAB path Pass
> Make binaries executable Pass

> Add Java paths for Excel format Pass
> Checking libSBML version 5.19.0
> Checking model import and export
> Import Excel format Pass
> Export Excel format Pass
> Import SBML format Pass
> Export SBML format Pass

> Checking for LP solvers
> glpk Pass
> gurobi Pass
> scip Fail
> cobra Pass
> Set RAVEN solver gurobi

> Checking BLAST+ Pass
> Checking DIAMOND Pass
> Checking HMMER Pass

> Checking function uniqueness Pass

*** checkInstallation complete ***

Running blastPlusTests
.
Done blastPlusTests

Running cdhitTests
.
Done cdhitTests

Running checkTasksTests
.
Done checkTasksTests

Running diamondTests
.
Done diamondTests

Running fillGapsLargeTests
..
Done fillGapsLargeTests

Running fillGapsSmallTests
...
Done fillGapsSmallTests

Running hmmerTests
.
Done hmmerTests

Running importExportTests
....
Done importExportTests

Running mafftTests
.
Done mafftTests

Running miriamTests
.
Done miriamTests

Running modelAbilitiesTests
........
Done modelAbilitiesTests

Running modelConversionTests
.
Done modelConversionTests

Running modelCurationTests
.......... ........
Done modelCurationTests

Running modelSortingTests
..
Done modelSortingTests

Running solverTests
..
Error occurred in solverTests/testSCIP and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using solverTests>testSCIP (line 80)
SCIP MEX binary not installed or not functional, test skipped
..
Done solverTests

Running tinitTests
..........
Done tinitTests

Failure Summary:

Name Failed Incomplete Reason(s)
=====================================================
solverTests/testSCIP X X Errored.

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk merged commit 1df6493 into develop Feb 24, 2024
1 check passed
@edkerk edkerk deleted the fix/makeBinaryExecutable branch February 24, 2024 13:21

for i=1:numel(binList)
[status,cmdout] = system(['chmod +x "' binList{i} '".(mexa64|mexglx|mexmaci64|mac|bat)']);
[status,cmdout] = system(['chmod +x "' binList{i} '"']);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me it looks like the meaningful change here is the position of the second ", which before was before the . and now is at the end. I'm also a bit unsure if quotation marks were needed at all - maybe it was a mechanism to deal with any spaces that would be found in the full path of binDir.

edkerk added a commit that referenced this pull request Apr 26, 2024
edkerk added a commit that referenced this pull request Apr 26, 2024
edkerk added a commit that referenced this pull request Apr 29, 2024
* chore: update to libSBML 5.20.2

* Revert "chore: update to libSBML 5.20.2" mexmaci64

This partially reverts commit cbfe73f.
Keep the old .mexmaci64 from release 5.18.3.

* fix: checkInstallation makeBinaryExecutable

Bug introduced by #528

* doc: software versions.txt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants