-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: makeBinaryExecutable explicit filenames #528
Conversation
This PR has been automatically tested with GH Actions. Here is the output of the tests: > Installing from location /home/m/actions-runner/_work/RAVEN/RAVEN
|
|
||
for i=1:numel(binList) | ||
[status,cmdout] = system(['chmod +x "' binList{i} '".(mexa64|mexglx|mexmaci64|mac|bat)']); | ||
[status,cmdout] = system(['chmod +x "' binList{i} '"']); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To me it looks like the meaningful change here is the position of the second "
, which before was before the .
and now is at the end. I'm also a bit unsure if quotation marks were needed at all - maybe it was a mechanism to deal with any spaces that would be found in the full path of binDir
.
Main improvements in this PR:
checkInstallation
correctly makes binaries executable on Ubuntu (solves bug: make binaries executable on Ubuntu #527)I hereby confirm that I have:
develop
as a target branch