Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: importModel if SBML contains missing SBO terms #536

Merged
merged 5 commits into from
May 2, 2024
Merged

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Apr 27, 2024

Main improvements in this PR:

  • fix:
    • importModel correctly parses SBML file that has some missing SBO terms

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

@edkerk edkerk changed the base branch from main to develop April 27, 2024 10:30
Copy link

github-actions bot commented Apr 27, 2024

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 > Installing from location             /home/m/actions-runner/_work/RAVEN/RAVEN
> Checking RAVEN release DEVELOPMENT
> Checking MATLAB release 2020b
> Checking system architecture glnxa64
> Set RAVEN in MATLAB path Pass
> Save MATLAB path Pass
> Make binaries executable Pass

> Add Java paths for Excel format Pass
> Checking libSBML version 5.20.2
> Checking model import and export
> Import Excel format Pass
> Export Excel format Pass
> Import SBML format Pass
> Export SBML format Pass

> Checking for LP solvers
> glpk Pass
> gurobi Fail
> scip Fail
> cobra Pass
> Set RAVEN solver glpk

> Checking BLAST+ Pass
> Checking DIAMOND Pass
> Checking HMMER Pass

> Checking function uniqueness Pass

*** checkInstallation complete ***

Running blastPlusTests
.
Done blastPlusTests

Running cdhitTests
.
Done cdhitTests

Running checkTasksTests
.
Done checkTasksTests

Running diamondTests
.
Done diamondTests

Running fillGapsLargeTests

Error occurred in fillGapsLargeTests/testLargeGurobi and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using fillGapsLargeTests>testLargeGurobi (line 32)
Solver not working
.
Error occurred in fillGapsLargeTests/testLargeSCIP and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using setRavenSolver (line 35)
SCIP not found. RAVEN only provides the precompiled SCIP MEX binary for Windows. Instructions on how to compile the SCIP MEX file are found at
https://github.com/scipopt/MatlabSCIPInterface

Error in fillGapsLargeTests>testLargeSCIP (line 56)
setRavenSolver('scip');
.
Done fillGapsLargeTests

Running fillGapsSmallTests

Error occurred in fillGapsSmallTests/testSmallSCIP and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using setRavenSolver (line 35)
SCIP not found. RAVEN only provides the precompiled SCIP MEX binary for Windows. Instructions on how to compile the SCIP MEX file are found at
https://github.com/scipopt/MatlabSCIPInterface

Error in fillGapsSmallTests>testSmallSCIP (line 16)
setRavenSolver('scip');
.
Error occurred in fillGapsSmallTests/testSmallGurobi and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using fillGapsSmallTests>testSmallGurobi (line 67)
Solver not working
.
Done fillGapsSmallTests

Running hmmerTests
.
Done hmmerTests

Running importExportTests
....
Done importExportTests

Running mafftTests
.
Done mafftTests

Running miriamTests
.
Done miriamTests

Running modelAbilitiesTests
........
Done modelAbilitiesTests

Running modelConversionTests
.
Done modelConversionTests

Running modelCurationTests
.......... ........
Done modelCurationTests

Running modelSortingTests
..
Done modelSortingTests

Running solverTests
.
Error occurred in solverTests/testGurobi and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using solverTests>testGurobi (line 60)
Solver not working
.
Error occurred in solverTests/testSCIP and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using solverTests>testSCIP (line 77)
SCIP MEX binary not installed or not functional, test skipped
..
Done solverTests

Running tinitTests
.
Error occurred in tinitTests/testftINIT_T0001 and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using dispEM (line 49)
Failed to find good enough solution within the time frame. MIPGap: Inf


Error in ftINIT (line 281)
dispEM(['Failed to find good enough solution within the time frame. MIPGap: ' num2str(mipGap)]);

Error in tinitTests>testftINIT_T0001 (line 237)
[~,tst1ResModel1] = evalc('ftINIT(prepDataTest1,arrayData1.tissues{1},[],[],arrayData1,[],getINITSteps(),true,true,testParams,false);');
.
Error occurred in tinitTests/testftINIT_T0002 and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using dispEM (line 49)
Failed to find good enough solution within the time frame. MIPGap: Inf


Error in ftINIT (line 281)
dispEM(['Failed to find good enough solution within the time frame. MIPGap: ' num2str(mipGap)]);

Error in tinitTests>testftINIT_T0002 (line 277)
[~,tst1ResModel1] = evalc('ftINIT(prepDataTest1,arrayData1.tissues{1},[],[],arrayData1,[],getINITSteps(),true,true,testParams,false);');
.....
Error occurred in tinitTests/testftINIT_T0008 and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using dispEM (line 49)
Failed to find good enough solution within the time frame. MIPGap: Inf


Error in ftINIT (line 281)
dispEM(['Failed to find good enough solution within the time frame. MIPGap: ' num2str(mipGap)]);

Error in tinitTests>testftINIT_T0008 (line 377)
[~,tst1ResModel1] = evalc('ftINIT(prepDataTest1,arrayData1.tissues{1},[],[],arrayData1,[],getINITSteps(),true,true,testParams,false);');
..
Error occurred in tinitTests/testftINIT_T0050 and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using dispEM (line 49)
Failed to find good enough solution within the time frame. MIPGap: Inf


Error in ftINIT (line 281)
dispEM(['Failed to find good enough solution within the time frame. MIPGap: ' num2str(mipGap)]);

Error in tinitTests>testftINIT_T0050 (line 543)
[~,mres] = evalc('ftINIT(prepDataL,arrayDataL.tissues{1},[],[],arrayDataL,[],getINITSteps(),true,true,testParams,false);');
.
Done tinitTests

Failure Summary:

Name Failed Incomplete Reason(s)
===================================================================
fillGapsLargeTests/testLargeGurobi X X Errored.
-------------------------------------------------------------------
fillGapsLargeTests/testLargeSCIP X X Errored.
-------------------------------------------------------------------
fillGapsSmallTests/testSmallSCIP X X Errored.
-------------------------------------------------------------------
fillGapsSmallTests/testSmallGurobi X X Errored.
-------------------------------------------------------------------
solverTests/testGurobi X X Errored.
-------------------------------------------------------------------
solverTests/testSCIP X X Errored.
-------------------------------------------------------------------
tinitTests/testftINIT_T0001 X X Errored.
-------------------------------------------------------------------
tinitTests/testftINIT_T0002 X X Errored.
-------------------------------------------------------------------
tinitTests/testftINIT_T0008 X X Errored.
-------------------------------------------------------------------
tinitTests/testftINIT_T0050 X X Errored.

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk merged commit 49d0057 into develop May 2, 2024
1 check passed
@edkerk edkerk deleted the fix/SBOterms branch May 2, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant