Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAVEN 2.9.3 #553

Merged
merged 2 commits into from
Jul 31, 2024
Merged

RAVEN 2.9.3 #553

merged 2 commits into from
Jul 31, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Jul 17, 2024

Main improvements in this PR:

  • fix:
    • ravenCobraWrapper handle empty rxnReferences from COBRA => RAVEN
    • replaceMets should not contract the whole model, only for the replaced metabolites
    • getBlast can handle paths containing spaces, or makes a custom temp path if required (solves Blast+ in RAVEN #506)
    • importModel with empty confidenceScores entries
    • constructS avoid warning about "Colon operands must be real scalars"
    • randomSampling should output the solutions as full matrix, as sparse matrices occassionally acts weird when using functions like mean
  • feature:
    • getIndexes supports ecenzymes, ecrxns and ecgenes types, to query GECKO3 model.ec fields
  • refactor:
    • speedup readYAMLmodel
  • docs
    • update badges and refer to GitHub Discussions instead of Gitter

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

…tIndexes (#551)

* refactor: speedup readYAMLmodel

* fix: ravenCobraWrapper rxnReferences cobra=>raven

* feat: getIndexes ec-fields

* fix: replaceMets only contracts rxns with replMets

* fix: getBlast handles spaces in path

also more informative error message

* fix: importModel with empty confidenceScores

* refactor: checkInstallation duplicate warning

* fix: KEGG model empty subSystems

* doc: getIndexes error if model has duplicate IDs

* fix: getDiamond fails unittest

* fix: getIndexes move ec-field check

* fix: constructS avoid warning

"Colon operands must be real scalars"

* fix: randomSampling outputs full matrix

sparse matrix can give weird summary results when applying functions like min, max, mean etc.

* fix: getBlast if temppath has space char
Copy link

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 > Installation type                    Advanced (via git)
> Installing from location /home/m/actions-runner/_work/RAVEN/RAVEN
> Checking RAVEN release 2.9.2
> You are running the latest RAVEN release
> Checking MATLAB release 2020b
> Checking system architecture glnxa64
> Set RAVEN in MATLAB path Pass
> Save MATLAB path Pass
> Make binaries executable Pass

> Add Java paths for Excel format Pass
> Checking libSBML version 5.20.2
> Checking model import and export
> Import Excel format Pass
> Export Excel format Pass
> Import SBML format Pass
> Export SBML format Pass

> Checking for LP solvers
> glpk Pass
> gurobi Pass
> scip Fail
> cobra Pass
> Set RAVEN solver glpk

> Checking BLAST+ Pass
> Checking DIAMOND Pass
> Checking HMMER Pass

> Checking function uniqueness Pass

*** checkInstallation complete ***

SCIP MEX binary not installed or not functional, some fillGapsLargeTests skipped.
SCIP MEX binary not installed or not functional, some fillGapsSmallTests skipped.
Running blastPlusTests
.
Done blastPlusTests

Running cdhitTests
.
Done cdhitTests

Running checkTasksTests
.
Done checkTasksTests

Running diamondTests
.
Done diamondTests

Running fillGapsLargeTests
.
Done fillGapsLargeTests

Running fillGapsSmallTests
.
Done fillGapsSmallTests

Running hmmerTests
.
Done hmmerTests

Running importExportTests
....
Done importExportTests

Running mafftTests
.
Done mafftTests

Running miriamTests
.
Done miriamTests

Running modelAbilitiesTests
........
Done modelAbilitiesTests

Running modelConversionTests
.
Done modelConversionTests

Running modelCurationTests
.......... ........
Done modelCurationTests

Running modelSortingTests
..
Done modelSortingTests

Running solverTests
..
Error occurred in solverTests/testSCIP and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using solverTests>testSCIP (line 77)
SCIP MEX binary not installed or not functional.
..
Done solverTests

Running tinitTests
..........
Done tinitTests

Failure Summary:

Name Failed Incomplete Reason(s)
=====================================================
solverTests/testSCIP X X Errored.

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk merged commit 33188fd into main Jul 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant