Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various functions #557

Merged
merged 8 commits into from
Sep 22, 2024
Merged

fix: various functions #557

merged 8 commits into from
Sep 22, 2024

Conversation

edkerk
Copy link
Member

@edkerk edkerk commented Sep 15, 2024

Main improvements in this PR:

  • Fixes:
    • importModel allows for empty parameters when not specified
    • constructS gives correct error message when a metabolite is missing
    • importExcelModel can ignore faulty MIRIAM entries (note: import of Excel models is strongly discouraged!)
    • checkModelStruct to determine if reaction is reversible, consider all combinations of LB and UB, not just whether LB < 0 or not
    • checkModelStruct checks that all genes in grRules field are also in genes field (solves checkModelStruct should compare .genes and .grRules #556)
  • Documentation:
    • getKEGGModelForOrganism explicitly refers to the correct dataDir options (i.e. prok90_kegg105 or euk90_kegg105 at this time)
  • Features:

Instructions on merging this PR:

  • This PR has develop as target branch, and will be resolved with a squash-merge.
  • This PR has main as target branch, and will be resolved with a merge commit.

@edkerk edkerk added this to the 2.9.4 milestone Sep 15, 2024
Copy link

This PR has been automatically tested with GH Actions. Here is the output of the tests:

 > Installation type                    Advanced (via git)
> Installing from location /home/m/actions-runner/_work/RAVEN/RAVEN
> Checking RAVEN release DEVELOPMENT
> Checking MATLAB release 2020b
> Checking system architecture glnxa64
> Set RAVEN in MATLAB path Pass
> Save MATLAB path Pass
> Make binaries executable Pass

> Add Java paths for Excel format Pass
> Checking libSBML version 5.20.2
> Checking model import and export
> Import Excel format Pass
> Export Excel format Pass
> Import SBML format Pass
> Export SBML format Pass

> Checking for LP solvers
> glpk Pass
> gurobi Pass
> scip Fail
> cobra Pass
> Set RAVEN solver glpk

> Checking BLAST+ Pass
> Checking DIAMOND Pass
> Checking HMMER Pass

> Checking function uniqueness Pass

*** checkInstallation complete ***

SCIP MEX binary not installed or not functional, some fillGapsLargeTests skipped.
SCIP MEX binary not installed or not functional, some fillGapsSmallTests skipped.
Running blastPlusTests
.
Done blastPlusTests

Running cdhitTests
.
Done cdhitTests

Running checkTasksTests
.
Done checkTasksTests

Running diamondTests
.
Done diamondTests

Running fillGapsLargeTests
.
Done fillGapsLargeTests

Running fillGapsSmallTests
.
Done fillGapsSmallTests

Running hmmerTests
.
Done hmmerTests

Running importExportTests
....
Done importExportTests

Running mafftTests
.
Done mafftTests

Running miriamTests
.
Done miriamTests

Running modelAbilitiesTests
........
Done modelAbilitiesTests

Running modelConversionTests
.
Done modelConversionTests

Running modelCurationTests
.......... ........
Done modelCurationTests

Running modelSortingTests
..
Done modelSortingTests

Running solverTests
..
Error occurred in solverTests/testSCIP and it did not run to completion.
---------
Error ID:
---------
''
--------------
Error Details:
--------------
Error using solverTests>testSCIP (line 77)
SCIP MEX binary not installed or not functional.
..
Done solverTests

Running tinitTests
..........
Done tinitTests

Failure Summary:

Name Failed Incomplete Reason(s)
=====================================================
solverTests/testSCIP X X Errored.

Note: In the case of multiple test runs, this post will be edited.

@edkerk edkerk merged commit 1fac621 into develop Sep 22, 2024
1 check passed
@edkerk edkerk deleted the fix/tweaks branch September 22, 2024 11:31
@edkerk edkerk modified the milestones: 2.9.4, 2.10.0 Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant