Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add metDeltaG and rxnDeltaG fields #330

Conversation

cheng-yu-zhang
Copy link
Collaborator

@cheng-yu-zhang cheng-yu-zhang commented Feb 16, 2023

Main improvements in this PR:

Add physiological status ΔG for rxns and mets from Modelseed and yetfl. All the related data and code is in ../yeast-GEM/deltaG.

  1. ../yeast-GEM/deltaG/yeast-GEM_with_G/yeast.mat is the final model with ΔG. ΔG is store in field yeast.metsdeltaG and yeast.rxnsdeltaG.
  2. ../yeast-GEM/deltaG/model_from_yetfl/yeast8_thermo_curated.mat is the model from yetfl containing ΔG data.https://github.com/EPFL-LCSB/yetfl
  3. ../yeast-GEM/deltaG/met_G.csv" contains mets' ΔG, ID, smile from Modelseed database crawled by ../yeast-GEM/deltaG/code/get_seed_data.py
  4. ../yeast-GEM/deltaG/rxn_G.csv contains rxns' ΔG computed by https://github.com/maranasgroup/dGPredictor
  5. ../yeast-GEM/deltaG/code/adddeltaG.m adds ΔG into the model.
  6. ../yeast-GEM/deltaG/code/run_dgpredictor.py is used to calculate ΔG for the given rxns, but every mets in the rxn should have kegg identifer.

I hereby confirm that I have:

  • Tested my code with all requirements for running the model
  • Selected develop as a target branch (top left drop-down menu)
  • If needed, asked first in the Gitter chat room about this PR

@feiranl
Copy link
Collaborator

feiranl commented Feb 20, 2023

As a suggestion for better tracking, it would be preferable to save the Excel file in either a .tsv or .csv format. By the way, may I know the way deltaG will be utilized in the future? Is this calculation straightforward or will it be automatically computed for any new reactions added to the model in the future? Additional comments will be provided later this week.

@cheng-yu-zhang
Copy link
Collaborator Author

@feiranl I have change xlsx to csv. And run_dgpredictor.py is able to calculate the deltaG of given rxns.
Gibbs free energy is a thermodynamic potential that describes the reaction directionalities. On the basis of Gibbs-Helmhotz equation and Van 't Hoff equation, we can intergate metabolic concentration or metabolome into yeast-GEM. Because intracelluar metabolic concentration may vary with different growth period and the environment, especially temperature . Thus, the reaction directionalities may change. So, biochemically unrealistic solutions of FBA like free high-flux cycles or thermodynamically infeasible pathways can be avoided.

@edkerk edkerk force-pushed the Add-physiological-state-delta-G-from-yetfl-model-and-modelseed-database branch from a4df287 to 75a5f32 Compare July 2, 2023 17:41
@edkerk edkerk changed the base branch from main to add-new-reaction-after-correction July 2, 2023 17:42
@edkerk
Copy link
Member

edkerk commented Jul 2, 2023

Updated the process, now available from v8_6_4.m (in line with coming yeast-GEM version):

  1. Rebased to add reactions based on KEGG and MetaCyc annotations #304 to have model with latest reactions.
  2. Note that because of point 1, the dG-predictor has not yet been applied on all reactions. @cheng-yu-zhang model.rxns(4063:end) should be predicted with dG-predictor.
  3. The current code generates a model with the metDeltaG and rxnDeltaG fields, but these can currently not be exported in YAML or SBML model format. This can quite easily be implemented for YAML (to be done here: feat: add a delta G field for reactions/metabolites RAVEN#280), but uncertain on how to implement for SBML. This is the reason why the model files in this PR are not having any change included.
  4. loadYeastModel and saveYeastModel will add and save the fields, based on the table in /data/database/model_*DeltaG.csv.

@edkerk
Copy link
Member

edkerk commented Jul 2, 2023

With the code on SysBioChalmers/RAVEN#500 the deltaG fields are written to/read from the YAML file.

@edkerk edkerk force-pushed the Add-physiological-state-delta-G-from-yetfl-model-and-modelseed-database branch from 5838f4f to ed7b691 Compare July 2, 2023 20:32
Base automatically changed from add-new-reaction-after-correction to develop July 8, 2023 12:19
@edkerk edkerk force-pushed the Add-physiological-state-delta-G-from-yetfl-model-and-modelseed-database branch from 8e0f250 to 58acd90 Compare July 8, 2023 15:57
@edkerk edkerk changed the title add_deltaG_for_rxns_and_mets feat: add metDeltaG and rxnDeltaG fields Jul 8, 2023
@edkerk edkerk added this to the 8.7.0 milestone Jul 8, 2023
@edkerk edkerk mentioned this pull request Jul 8, 2023
3 tasks
@edkerk edkerk deleted the Add-physiological-state-delta-G-from-yetfl-model-and-modelseed-database branch July 15, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants