-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better Firmware Names #3766
Better Firmware Names #3766
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
I do not get why the Commit I made is changing the Line Endings. But I have redone the changes. That unifies the names for all the Firmware. |
I'd forgotten about #2204, but this is a follow-up to that. |
Renaming Firmware Files based on System Name as BizHawk uses or at least renamed to be related to what it's for. Unify Firmware names for PC-Engine, Vectrex, Lynx, MSX And resolve Name Collision, Odyssey 2 G7400, Gameboy, GameBoy Color.
I don't have an opinion on cosmetic changes changes that don't change UX. |
Okay, unless there's any further disagreement I'll just merge this later then; I've resolved the previous review comments myself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still think we should be using filenames found "in the wild", but I too don't really care. Diff LGTM.
Renaming Firmware Files based on System Name as BizHawk uses or at least renamed to be related to what it's for.
This changes the Auto-Renamed Firmware Files to be named based on the System ID.
Or to be more Descriptive. So the users can see helpful file names.
The File has been formatted to use LF instead of CRLF. Which is why it feels like a "Full Replacement"
Examples of Old Name:
cx4.rom
KoF95.bin
Examples of New Name:
SNES_cx4.rom
SAT_KoF95.bin
Also changed the MSX 1.0 BIOS and BASIC vs MSX BIOS and BASIC have their own filenames now instead of a Filename Collision.
Check if completed: