Bump AnalysisLevel to 8 #4131
Open
Bump AnalysisLevel to 8 #4131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bit of a controversial one maybe, but sadly this one isn't shown in the IDE so putting it on suggestion level is useless, so it's either warning or nothing.
This inspection is pretty jank and doesn't show half the time. I think it has its valid cases, but it shouldn't be on warning level.
Way too aggressive and even flags private static initializers that only run once. Unusable as is.
Morilli
added
the
Meta
I guarantee this never worked correctly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bumps the
AnalysisLevelfor code analyzers from 6 to 8, enabling more analyzers by default. This is now safe as we require the .NET 8 SDK to build.I've applied fixes and severity changes to all new inspections. Open to feedback on whether any of those are disagreed on.
Check if completed: