feat(inputNumber): inputNumber #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
duenyang
reviewed
Sep 25, 2024
src/input-number/input-number.tsx
Outdated
| @@ -1,20 +1,438 @@ | |||
| // 临时 input-number | |||
| import 'tdesign-icons-web-components'; | |||
src/input-number/input-number.tsx
Outdated
Comment on lines
31
to
42
| static css = ` | ||
| .t-input-number t-button-light-dom.t-input-number__decrease, | ||
| .t-input-number t-button-light-dom.t-input-number__increase { | ||
| border: none; | ||
| transition: none; | ||
| } | ||
|
|
||
| .t-input-number button.t-input-number__decrease, | ||
| .t-input-number button.t-input-number__increase { | ||
| position: static; | ||
| } | ||
| `; |
src/input-number/input-number.tsx
Outdated
| theme: 'row', | ||
| }; | ||
|
|
||
| static propTypes = {}; |
src/input-number/input-number.tsx
Outdated
| } | ||
|
|
||
| install(): void { | ||
| this.usedValue.value = this.props.value || this.props.defaultValue; |
There was a problem hiding this comment.
install里使用signal赋值，会多调用一次render；
这里this.usedValue 可以使用普通类变量，在需要更改的地方手动update
duenyang
approved these changes
Sep 25, 2024
This was referenced Oct 17, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个 PR 的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
📝 更新日志
feat(inputNumber): inputNumber
本条 PR 不需要纳入 Changelog
☑️ 请求合并前的自查清单