Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process @xml:id wherever the output of a <list> is generated #617

Merged
merged 1 commit into from
Sep 28, 2023

Conversation

sydb
Copy link
Member

@sydb sydb commented Jul 30, 2023

I am hoping this fixes #616
Relatively minor update to html/html_core.xsl: Just added a call to process the @xml:id attribute to each of the possible output elements generated for <list>. Just chose one when two elements were generated (despite my comment on the ticket : -).
My main surprise is that the tests all seemed to pass on my system. I would have expected diff errors when a test input file had a <list xml:id="DUCK"> whose output used to be <ul> but is now <ul id="DUCK">. Harumph.

@sydb sydb added this to the Release 7.56.0 milestone Jul 30, 2023
@tuurma
Copy link
Contributor

tuurma commented Aug 8, 2023

What do you mean "just chose one when two elements were generated"? Like, nested elements, e.g. p/dl or p/table in which case it seems the only sensible option.

@sydb
Copy link
Member Author

sydb commented Aug 10, 2023

Yes, @tuurma, that is what I think I meant.

@HelenaSabel HelenaSabel merged commit f6524f8 into dev Sep 28, 2023
4 checks passed
@raffazizzi raffazizzi added this to the Release 7.56.0 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xml:id on list element does not give a HTML id
5 participants