code cleanup

TESSEorg · Apr 5, 2024 · 1629d6a · 1629d6a
1 parent 2956f1f
commit 1629d6a
Showing 1 changed file with 29 additions and 114 deletions.
diff --git a/tests/unit/fibonacci_device.cc b/tests/unit/fibonacci_device.cc
@@ -1,46 +1,42 @@
-////
-
 #include <ttg.h>
-// Define TTG_USE_CUDA only if CUDA support is desired and available
-#ifdef TTG_USE_CUDA
+
+#if defined(TTG_HAVE_CUDA)
+#define ES ttg::ExecutionSpace::CUDA
 #include "cuda_runtime.h"
 #include "fibonacci_cuda_kernel.h"
+#else
+#error " CUDA  is required to build this test!"
 #endif
 
 #include "ttg/serialization.h"
 
-// Default to CUDA if available, can be overridden by defining TTG_USE_XXX for other backends
-#define ES ttg::default_execution_space()
-
+const int64_t F_n_max = 1000;
 /// N.B. contains values of F_n and F_{n-1}
 struct Fn : public ttg::TTValue<Fn> {
   int64_t F[2] = {1, 0};  // F[0] = F_n, F[1] = F_{n-1}
   ttg::Buffer<int64_t> b;
 
   Fn() : b(&F[0], 2) {}
 
+  Fn(const Fn&) = delete;
   Fn(Fn&& other) = default;
+  Fn& operator=(const Fn& other) = delete;
   Fn& operator=(Fn&& other) = default;
 
   template <typename Archive>
   void serialize(Archive& ar) {
-    ttg_abort();
+    ttg::ttg_abort();
   }
   template <typename Archive>
   void serialize(Archive& ar, const unsigned int) {
-    ttg_abort();
+    ttg::ttg_abort();
   }
 };
-
-int main(int argc, char* argv[]) {
-  ttg::initialize(argc, argv, -1);
-  const int64_t F_n_max = 1000;
-
-  ttg::Edge<int64_t, Fn> f2f;
-  ttg::Edge<void, Fn> f2p;
-
-  auto fib = ttg::make_tt<ES>(
-      [=](int64_t n, Fn& f_n) -> ttg::device::Task {
+extern ttg::Edge<int64_t, Fn> f2f;
+extern ttg::Edge<void, Fn> f2p;
+auto create_fib_task() {
+  return ttg::make_tt<ES>(
+      [=](int64_t n, Fn&& f_n) -> ttg::device::Task {
         assert(n > 0);
 
         co_await ttg::device::select(f_n.b);
@@ -51,110 +47,29 @@ int main(int argc, char* argv[]) {
         co_await ttg::device::wait(f_n.b);
 
         if (f_n.F[0] < F_n_max) {
-          co_await ttg::device::forward(ttg::device::send<0>(n + 1, f_n));
+          co_await ttg::device::forward(ttg::device::send<0>(n + 1, std::move(f_n)));
         } else {
-          co_await ttg::device::forward(ttg::device::sendv<1>(f_n));
+          co_await ttg::device::forward(ttg::device::sendv<1>(std::move(f_n)));
         }
       },
-      ttg::edges(f2f),
-      ttg::edges(f2f, f2p),
-      "fib");
+      ttg::edges(f2f), ttg::edges(f2f, f2p), "fib");
+  auto print = ttg::make_tt(
+      [](Fn f_n) {
+        std::cout << "The largest Fibonacci number smaller than " << F_n_max << " is " << f_n.F[1] << std::endl;
+      },
+      ttg::edges(f2p), ttg::edges(), "print");
+}
 
-  auto print = ttg::make_tt([](Fn f_n) {
-    std::cout << "The largest Fibonacci number smaller than" << F_n_max << " is " << f_n.F[1] << std::endl;
-  },
-                            ttg::edges(f2p),
-                            ttg::edges(),
-                            "print");
+int main(int argc, char* argv[]) {
+  ttg::initialize(argc, argv, -1);
+  auto fib = create_fib_task();
 
   ttg::make_graph_executable(fib.get());
   if (ttg::default_execution_context().rank() == 0) fib->invoke(1, Fn{});
 
-  ttg::execute(ttg_default_execution_context());
-  ttg::fence(ttg_default_execution_context());
+  ttg::execute(ttg::ttg_default_execution_context());
+  ttg::fence(ttg::ttg_default_execution_context());
 
   ttg::finalize();
   return 0;
 }
-
-//// Created by Hyndavi Venkatreddygari on 3/13/24.
-////
-//#include <ttg.h>
-//#define TTG_USE_CUDA
-//#include "cuda_runtime.h"
-//#include "cuda_kernel.h"
-//
-//#include "ttg/serialization.h"
-//
-//#define ES ttg::ExecutionSpace::CUDA
-//
-//struct A : public ttg::TTValue<A> {
-//  int64_t value;
-//  ttg::Buffer<int64_t> buffer;
-//
-//  A() : value(0), buffer(&value, 1) {}
-//  A(int64_t val) : value(val), buffer(&value, 1) {}
-//
-//  A(A&& other) = default;
-//  A& operator=(A&& other) = default;
-//
-//  template <typename Archive>
-//  void serialize(Archive& ar) {
-//    ttg_abort();
-//  }
-//  template <typename Archive>
-//  void serialize(Archive& ar, const unsigned int) {
-//    ttg_abort();
-//  }
-//};
-//
-//int main(int argc, char* argv[]) {
-//  ttg::initialize(argc, argv, -1);
-//  const int64_t N = 20;
-//
-//  ttg::Edge<int64_t, A> f2f;
-//  ttg::Edge<void, A> f2p;
-//
-//  auto fib = ttg::make_tt<ES>(
-//      [=](int64_t n, A& F_nms) -> ttg::device::Task {
-//        if (n <= N) {
-//          co_await ttg::device::select(F_nms.buffer);
-//
-//          int64_t* d_result;
-//          cudaMalloc(&d_result, sizeof(int64_t));
-//
-//          calculate_fibonacci(d_result, n);
-//
-//          co_await ttg::wait_kernel();
-//
-//          int64_t h_result;
-//          cudaMemcpy(&h_result, d_result, sizeof(int64_t), cudaMemcpyDeviceToHost);
-//
-//          A F_n(h_result);
-//          if (n < N) {
-//            co_await ttg::device::send<0>(n + 1, F_n);
-//          } else {
-//            co_await ttg::device::sendv<1>(F_n);
-//          }
-//        }
-//      },
-//      ttg::edges(f2f),
-//      ttg::edges(f2f, f2p),
-//      "fib");
-//
-//  auto print = ttg::make_tt([](A F_N) {
-//    std::cout << "The " << N << "th Fibonacci number is " << F_N.value << std::endl;
-//  },
-//                            ttg::edges(f2p),
-//                            ttg::edges(),
-//                            "print");
-//
-//  ttg::make_graph_executable(fib.get());
-//  if (ttg::default_execution_context().rank() == 0) fib->invoke(2, A(1));
-//
-//  ttg::execute(ttg_default_execution_context());
-//  ttg::fence(ttg_default_execution_context());
-//
-//  ttg::finalize();
-//  return 0;
-//}