SPMM: take input by reference, not by value #261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use input_refs_tuple_type instead of input_values_tuple_type. Otherwise inputs will be copied into the tuple, needlessly. Signed-off-by: Joseph Schuchart <[email protected]>
Signed-off-by: Joseph Schuchart <[email protected]>
therault
approved these changes
Jun 29, 2023
evaleev
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use input_refs_tuple_type instead of input_values_tuple_type. Otherwise inputs will be copied into the tuple, needlessly.
@Ashawini27 You probably want this patch for your performance measurements. Without it, tiles are copied excessively, limiting memory bandwidth and causing contention in the memory manager.
I'm not even sure why this is exposed, we should clean up the public interface of the TT...