Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update README with device example #282

Merged
merged 30 commits into from
Jun 9, 2024
Merged

update README with device example #282

merged 30 commits into from
Jun 9, 2024

Conversation

evaleev
Copy link
Contributor

@evaleev evaleev commented Apr 6, 2024

using data-dependent fibonacci example (find max(F_n) < N) as the motivating dataflow example

@evaleev evaleev force-pushed the hyndavi/feature/readme-update-device branch 4 times, most recently from 02b8c49 to 57c731c Compare April 9, 2024 12:08
@evaleev
device fib example is a standalone executable, takes N from command l…
66ab8ee 
…ine (default = 1000). Does not seem to invoke the kernel
@evaleev
address of Fn::F must be invariant under move ... use std::unique_ptr…
ca4c976 
… which makes Fn truly move-only. Still fails in last send when trying to copy Fn
@evaleev evaleev force-pushed the hyndavi/feature/readme-update-device branch 2 times, most recently from 28bbbb8 to 7988578 Compare April 9, 2024 13:12
@evaleev evaleev force-pushed the hyndavi/feature/readme-update-device branch from 7988578 to b9ae723 Compare April 9, 2024 13:15
@evaleev evaleev requested a review from devreal April 9, 2024 13:26
devreal
devreal approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@devreal devreal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @evaleev! Changes look good. Technically, we could use move-only types in broadcasts but I'm fine with the stricter constraint. We can relax that later if we have to.

@devreal
Copy link
Contributor

devreal commented Jun 5, 2024

This looks good but should we add a section on environment variables? I guess the only relevant one right now is TTG_NUM_THREADS.

@evaleev evaleev force-pushed the hyndavi/feature/readme-update-device branch from 83a9f70 to e99f2e7 Compare June 9, 2024 15:50
@evaleev evaleev merged commit e7ba5a6 into master Jun 9, 2024
@evaleev evaleev deleted the hyndavi/feature/readme-update-device branch June 9, 2024 16:09
@evaleev
Copy link
Contributor Author

evaleev commented Jun 9, 2024

@devreal I made some changes to the device example discussion, would appreciate your proof ... here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devreal devreal devreal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evaleev @devreal @hyndavi17