Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension broken as of SM 1.12 revision 6998 #38

Closed
Kenzzer opened this issue Mar 30, 2023 · 2 comments · Fixed by #39
Closed

Extension broken as of SM 1.12 revision 6998 #38

Kenzzer opened this issue Mar 30, 2023 · 2 comments · Fixed by #39

Comments

@Kenzzer
Copy link
Collaborator

Kenzzer commented Mar 30, 2023

alliedmodders/sourcemod#1908 Has broken the method by which we cleared datamap cache, building and loading the ext against newer versions of sourcemod will most certainly memory corrupt everything if not outright crash.

Fortunately there's a PR that is going to address that. However it won't be exposed to extensions right away which sucks, the gamehelpers interface must be updated... So this PR is pretty much useless on its own
alliedmodders/sourcemod#1943

In the meanwhile, I suggest we continue our hacking into CHalfLife2 as before
https://github.com/TF2-DMB/CBaseNPC/blob/09ea2e4d5aecc772ff6abd11abfaa3de149ea1b3/extension/idatamapcontainer.cpp#L831L841
However, since we're maintaining compatibility with sm 1.11. This means we have to split to build pipeline, and begin to make release against sm 1.11 and 1.12 respectively.

@Kenzzer Kenzzer changed the title Extension broken as of SM Extension broken as of SM 1.12 revision 6998 Mar 30, 2023
@sirdigbot
Copy link

Updated alliedmodders/sourcemod#1943 to accommodate this.

@Kenzzer
Copy link
Collaborator Author

Kenzzer commented Mar 31, 2023

Thank you for the changes !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants