Late spring-clean #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitRifty
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Tested with both 1.12.7024 and 1.12.6983 on Windows by repeatedly reloading the Scout NextBot plugin and I didn't run into any issues.
Having to rely on the "sourcemod_version" cvar is a huge stinker but seems like the most effective solution for now. Once 1.12 becomes stable, the CHalfLife2 hack should be revisited, as well as when we decide to drop 1.11 support and/or alliedmodders/sourcemod#1943 gets merged, whichever comes first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Its time for some clean up around the extension.
First we add smsdk_ext.cpp, while it has no uses as of right now. It might become useful, if PR Deprecate CreateInterface alliedmodders/sourcemod#2001 isn't merged by the time we use more functionalities from tier1.
This fixes Extension broken as of SM 1.12 revision 6998 #38. And because Add methods for clearing netprop cache alliedmodders/sourcemod#1943 still isn't merged, we can't rely on the gameinterface versioning to tell which definition of
CHalfLife2we're dealing with. So we piggy back off sourcemod's version convar. I've dug for alternatives that wouldn't require parsing the convar, but SM is completely opaque when it comes to letting plugins or extensions which version is currently running.Finally, ubuntu-18 has been deprecated for github CI. So replace it with the image ubuntu-19. I've also added windows-latest to the os matrix, since windows-2022 has become available and no longer maps to windows-2019 which we were already building against.