Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PtrToPawnAddress to action callbacks #43

Merged
merged 4 commits into from
Aug 23, 2023
Merged

Add PtrToPawnAddress to action callbacks #43

merged 4 commits into from
Aug 23, 2023

Conversation

KitRifty
Copy link
Collaborator

@KitRifty KitRifty commented Aug 22, 2023 •
edited
Loading

Changes:

  • Added uses of PtrToPawnAddress and PawnAddressToPtr for the action callbacks.
  • Replaced the event result stack of an Action with a counter instead.
    • The event result is assigned after the event has been processed, so there's no risk of overwriting the result if an event is triggered inside of another.

@KitRifty KitRifty marked this pull request as draft August 22, 2023 21:42
@KitRifty KitRifty marked this pull request as ready for review August 22, 2023 23:09
@KitRifty KitRifty marked this pull request as draft August 22, 2023 23:48
@KitRifty KitRifty changed the title Fix events triggered in OnEnd() not propagating Add PtrToPawnAddress to action callbacks Aug 23, 2023
@KitRifty KitRifty marked this pull request as ready for review August 23, 2023 15:29
KitRifty and others added 4 commits August 23, 2023 23:59
@KitRifty @Kenzzer
Propagate events triggered in OnEnd()
d2ef341 
Replace event result stack with counter
PtrToPawnAddress leftovers for actions
@KitRifty @Kenzzer
Skip events for ending actions
2f02271 
 - It doesn't really make sense for events to be processed when an action is being transitioned out (their event result doesn't even matter!). Events should be processed by actions that are still running though.
@KitRifty @Kenzzer
Strip modified event propagation
710b693 
Revert changes to example plugin
@Kenzzer
Update product.version
6ebde93
@Kenzzer Kenzzer merged commit 662c5b9 into master Aug 23, 2023
7 checks passed
@Kenzzer Kenzzer deleted the action-onend-events branch August 23, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kenzzer Kenzzer Kenzzer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KitRifty @Kenzzer