Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup discord integration code #314

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Commits on Aug 11, 2024

  1. Move button interaction code to subcomponents

    Now the code for each interaction for a command is defined in the original command file
    instead of one big file that implements the logic for all commands.
    JJ-8 committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    bb60ef6 View commit details
    Browse the repository at this point in the history
  2. Include challanges-talk channel with one message in archive

    The challenges-talk channel is the only channel that does not have a Discord bot message in it,
    so we should include everything in the channel.
    JJ-8 committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    d0eee56 View commit details
    Browse the repository at this point in the history
  3. Move command.ts and commands.ts to the commands directory

    These command implementations are a specific implementation of handling interaction,
    so it should not be in the global folder.
    JJ-8 committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    91f96d9 View commit details
    Browse the repository at this point in the history
  4. Separate global Discord logic from agile implementation

    When we want to introduce new ways of interacting with Discord, we need to separate the current 'agile' implementation with everything else.
    This folder structure makes much more sense therefore.
    JJ-8 committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    7bb612e View commit details
    Browse the repository at this point in the history
  5. Dynamically import Commands and Interactions based on handle style

    In the future we want to be able to change the handle style of the Discord bot (see #239).
    Now we have an easy way of adding new handle styles which can be toggled by .env configuration.
    
    Only the discordHooks.ts needs to be split and reorganized for this to fully work.
    JJ-8 committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    eb1511d View commit details
    Browse the repository at this point in the history
  6. Move channels.ts to agile folder

    The channels.ts file is created with the agile workflow in mind.
    Therefore it belongs to the agile subdirectory and it is not a general utility file.
    JJ-8 committed Aug 11, 2024
    Configuration menu
    Copy the full SHA
    a41f44b View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2024

  1. Configuration menu
    Copy the full SHA
    50ff871 View commit details
    Browse the repository at this point in the history
  2. Dynamically import Discord hooks

    Just like the commands and interactions, the hooks are now also dynamically imported.
    JJ-8 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    6906497 View commit details
    Browse the repository at this point in the history
  3. Refactor agile hooks to separate functions and switch statement

    This reduces the cognitive complexity a lot and allows for more reusable setup.
    JJ-8 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    9adb5b3 View commit details
    Browse the repository at this point in the history
  4. Move handleCreateTask to solveTask.ts

    It makes more sense to have this function here than in the hooks.ts
    since it is related to solving a task and not for hooking.
    JJ-8 committed Aug 25, 2024
    Configuration menu
    Copy the full SHA
    8196865 View commit details
    Browse the repository at this point in the history