Instructions for has_notices on plugin level #750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
reviewed
Jul 10, 2018
| @@ -115,6 +116,7 @@ force_activation | boolean | v2.2.0 | Either `true` or `false`. Defaults to `fal | |||
| force_deactivation | boolean | v2.2.0 | Either `true` or `false`. Defaults to `false`.<br>If set to `true`, it forces the specified plugin to be deactivated when the current theme is switched. This is useful for deactivating theme-specific plugins. | |||
| external_url | string | v2.2.0 | An external URL for the plugin.<br>By default, plugins referenced from the WordPress Plugin Repository are linked to their plugin information via a thickbox overlay. This parameter overrides this default behavior and allows you to specify an alternative URL for the plugin which - when clicked - will be opened in a new tab/window. | |||
| is_callable | string\|array | v2.5.0 | Advanced feature. If a plugin can be installed under two or more different slugs - for instance a basic version and a premium version using different slugs -, it might not be recognized correctly as active.<br>By setting `is_callable` to either a function `function_name` from that plugin or a class method - `array( 'class', 'method' )` - similar to how you hook in to actions and filters - TGMPA can still recognize the plugin as being active. | |||
| has_notices | boolean | v2.7.0 | Either `true` or `false`. Additinal feature that shows/hides the plugin in administrator notice. Useful to hide notice for recommended plugins. Default value is `true`. | |||
There was a problem hiding this comment.
Minor text order and layout change suggestion to be more consistent with the other entries:
Either true or false. Defaults to true.<br>... explanation phrase ...
Also: Additinal => Additional
The text may need further adjustment depending on the discussion I initiated in #749 (review)
There was a problem hiding this comment.
will do in about 2h, thnx for pointers.
|
Just FYI: this PR should (will) not be merged until we release the version in which PR #749 has been merged to prevent confusing people by mentioning on the website a feature which hasn't been released yet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.